-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Set up pages for application security for java #30004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
bd906b8
to
387942a
Compare
ea3e81e
to
24a39c1
Compare
2675da4
to
f48a343
Compare
10b5363
to
90560e6
Compare
9636440
to
7498cdb
Compare
Signed-off-by: sezen.leblay <[email protected]> Co-authored-by: Julio Guerra <[email protected]>
7498cdb
to
da64645
Compare
now deferring the review to the final reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
<ol> | ||
<li>If your Java service already has APM tracing set up and running, then skip to <a href="#automatically-enabling-app-and-api-protection-through-remote-configuration">service configuration</a></li> | ||
<li>If your Java service doesn't have APM tracing set up, you can easily enable App and API Protection with Datadog's <a href="https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/single-step-apm/{{ .Get "platform" }}/">Automatic Installation</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented the same in the Ruby's documentation PR, in this line we are talking about "enable Ap and API Protection" but the content of the link is talking only about APM enablement, not AAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's a limitation indeed of the current SSI documentation.
I suggest we open a separate PR adding somewhere in SSI's doc that SSI allows to enable more than APM?
layouts/shortcodes/app_and_api_protection_java_setup_options.md
Outdated
Show resolved
Hide resolved
layouts/shortcodes/app_and_api_protection_java_setup_options.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/windows/_index.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/windows/_index.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/kubernetes/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Cretzman <[email protected]>
761d5e8
to
3de2877
Compare
What does this PR do? What is the motivation?
https://datadoghq.atlassian.net/browse/APPSEC-57937
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes