Skip to content

Set up pages for application security for java #30004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 11, 2025

Conversation

sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Jun 18, 2025

What does this PR do? What is the motivation?

https://datadoghq.atlassian.net/browse/APPSEC-57937

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jun 18, 2025
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Preview links (active after the build_preview check completes)

New or renamed files

Removed or renamed files (these should redirect)

Modified Files

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch 9 times, most recently from bd906b8 to 387942a Compare June 19, 2025 11:47
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch 7 times, most recently from ea3e81e to 24a39c1 Compare June 20, 2025 14:49
@sezen-datadog sezen-datadog marked this pull request as ready for review June 23, 2025 08:00
@sezen-datadog sezen-datadog requested review from a team as code owners June 23, 2025 08:00
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch from 2675da4 to f48a343 Compare June 23, 2025 10:42
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch 3 times, most recently from 10b5363 to 90560e6 Compare June 23, 2025 14:35
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch 5 times, most recently from 9636440 to 7498cdb Compare July 1, 2025 09:32
Signed-off-by: sezen.leblay <[email protected]>
Co-authored-by: Julio Guerra <[email protected]>
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch from 7498cdb to da64645 Compare July 1, 2025 09:57
@sezen-datadog sezen-datadog marked this pull request as ready for review July 1, 2025 10:20
@Julio-Guerra Julio-Guerra removed their request for review July 1, 2025 19:45
@Julio-Guerra Julio-Guerra dismissed their stale review July 1, 2025 19:46

now deferring the review to the final reviewers

Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


<ol>
<li>If your Java service already has APM tracing set up and running, then skip to <a href="#automatically-enabling-app-and-api-protection-through-remote-configuration">service configuration</a></li>
<li>If your Java service doesn't have APM tracing set up, you can easily enable App and API Protection with Datadog's <a href="https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/single-step-apm/{{ .Get "platform" }}/">Automatic Installation</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented the same in the Ruby's documentation PR, in this line we are talking about "enable Ap and API Protection" but the content of the link is talking only about APM enablement, not AAP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's a limitation indeed of the current SSI documentation.
I suggest we open a separate PR adding somewhere in SSI's doc that SSI allows to enable more than APM?

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/aap-setup-page-java branch from 761d5e8 to 3de2877 Compare July 9, 2025 15:01
@github-actions github-actions bot added the Guide Content impacting a guide label Jul 11, 2025
@sezen-datadog sezen-datadog merged commit bdf37ed into master Jul 11, 2025
15 checks passed
@sezen-datadog sezen-datadog deleted the sezen.leblay/aap-setup-page-java branch July 11, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants