profiling: store trace endpoint in profiling events #2573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
force-pushed
the
profiling/embed-resource-name
branch
from
e6ba01c to
ed6a6b7
Compare
jd
added
the
changelog/no-changelog
jd
force-pushed
the
profiling/embed-resource-name
branch
from
ed6a6b7 to
ded77b9
Compare
mar-kolya
reviewed
Jun 23, 2021
P403n1x87
reviewed
Jun 23, 2021
Yun-Kim
previously approved these changes
Jun 23, 2021
jd
force-pushed
the
profiling/embed-resource-name
branch
from
ded77b9 to
33a1f8d
Compare
P403n1x87
reviewed
Jun 24, 2021
P403n1x87
reviewed
Jun 24, 2021
| @@ -346,6 +349,8 @@ | |||
| thread_native_id=123987, | |||
| thread_name="MainThread", | |||
| trace_id=1322219321, | |||
| trace_resource="notme", | |||
| trace_type="sql", | |||
There was a problem hiding this comment.
Is this and the one below intentional or should have been SpanTypes.SQL.value?
There was a problem hiding this comment.
Whatever. I mean both works and are valid here.
What we want is that if it's not SpanTypes.WEB we don't store any trace_resource, so it being the "SQL" span type or the customer sql, it must be the same behaviour :)
| self, event # type: lock.LockEventBase | ||
| ): | ||
| if event.trace_type == ext.SpanTypes.WEB.value: | ||
| trace_resource = self._none_to_str(event.trace_resource) |
There was a problem hiding this comment.
there is likely an edge case with a few integrations where we don't set the resource until after the request has finished.
Pylons does this, not sure how many others, but could imagine if we don't get the resource before creating the span, could still be a race condition on whether we have it or not
There was a problem hiding this comment.
Right, though I am not sure this should block this PR?
That sounds like it's something we want to "improve" as possible in integrations.
P403n1x87
approved these changes
Jun 30, 2021
Kyle-Verhoog
approved these changes
Jun 30, 2021
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Jul 15, 2021
This extends the previous behavior of TraceIdentifiers::Ddtrace to also return the root span resource, which will be used to enable aggregation-by-endpoint functionality in the profiler. Due to PII concerns (as explained in the comments), we start with a rather conservative filter of only allowing HTTP::TYPE_INBOUND traces. I took some inspiration from the similar implementation for Python (<DataDog/dd-trace-py#2573>) although I still need to validate with the wider team that the current filtering approach is reasonable for Ruby tracing as well.
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Jul 15, 2021
This extends the previous behavior of TraceIdentifiers::Ddtrace to also return the root span resource, which will be used to enable aggregation-by-endpoint functionality in the profiler. Due to PII concerns (as explained in the comments), we start with a rather conservative filter of only allowing HTTP::TYPE_INBOUND traces. I took some inspiration from the similar implementation for Python (<DataDog/dd-trace-py#2573>) although I still need to validate with the wider team that the current filtering approach is reasonable for Ruby tracing as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(profiling): store trace resource in profiling events
feat(pprof): export trace resource in profiles