fix(di): remote re-enablement#17158
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Mar 30, 2026
Merged
fix(di): remote re-enablement#17158gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
We fix the logic that controls remote enablement for Dynamic Instrumentation. Previously, if DI was enabled via environment variable and then disabled via the UI, any new attempts at re-enabling it remotely would be ignored. We fix the logic to look at the original parsed value from the environment variable instead of any potential runtime overrides instead.
P403n1x87
added
changelog/no-changelog
Codeowners resolved as |
avara1986
approved these changes
Mar 27, 2026
tylfin
approved these changes
Mar 27, 2026
Member
tylfin
left a comment
tylfin
left a comment
There was a problem hiding this comment.
Do we know when this broke? Do we need backports?
Contributor
|
This change is marked for backport to 4.6, but it conflicts with that branch. The command used to test backporting was |
Contributor
Author
I think this has been broken since the early remote enablement days 🤔 |
Contributor
Author
|
backport requires #17114 |
brettlangdon
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Description We fix the logic that controls remote enablement for Dynamic Instrumentation. Previously, if DI was enabled via environment variable and then disabled via the UI, any new attempts at re-enabling it remotely would be ignored. We fix the logic to look at the original parsed value from the environment variable instead of any potential runtime overrides instead. Co-authored-by: gabriele.tornetta <gabriele.tornetta@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We fix the logic that controls remote enablement for Dynamic Instrumentation. Previously, if DI was enabled via environment variable and then disabled via the UI, any new attempts at re-enabling it remotely would be ignored. We fix the logic to look at the original parsed value from the environment variable instead of any potential runtime overrides instead.