-
Notifications
You must be signed in to change notification settings - Fork 495
fix(llmobs): handle multimodal content parts in Chat Completions input messages #17126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jessicagamio
wants to merge
5
commits into
DataDog:main
from
jessicagamio:jessica.gamio/fix-MLOS-543-multimodal-chat-content
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
24eb050
fix(llmobs): handle multimodal content parts in Chat Completions inpu…
jessicagamio 3112bd7
Merge branch 'main' into jessica.gamio/fix-MLOS-543-multimodal-chat-c…
jessicagamio fce2986
Merge branch 'main' into jessica.gamio/fix-MLOS-543-multimodal-chat-c…
jessicagamio fc92735
chore(llmobs): add release note for multimodal chat content fix
jessicagamio 4428061
Merge branch 'main' into jessica.gamio/fix-MLOS-543-multimodal-chat-c…
jessicagamio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
releasenotes/notes/fix-multimodal-chat-content-cf726c0b53dbf68f.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| fixes: | ||
| - | | ||
| LLM Observability: Fix handling of multimodal content parts in Chat Completions input messages. Messages with list-type content (e.g. text + image_url parts) are now correctly extracted instead of being serialized as a raw list string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch only parses multimodal parts when
contentis alist, so any SDK object that exposes parts as a non-list iterable (for example PydanticValidatorIterator/Iterablewrappers) still falls through tostr(raw_content)and produces the same unreadable placeholder representation this fix is meant to eliminate. In those inputs, LLMObs will keep recording validator object strings instead of prompt text/image markers.Useful? React with 👍 / 👎.