-
Notifications
You must be signed in to change notification settings - Fork 452
chore(span): remove Span._context #14189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 291 ± 4 ms. The average import time from base is: 292 ± 4 ms. The import time difference between this PR and base is: -0.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: munir/remove-internal-context-field (1c0a1cd) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
This PR removes the internal Span._context property and ensures that Span.context is never None.
The current memory utilization benchmarks are too simplistic and don't account for scenarios where a Span is initialized with a Context. Since it's not possible to generate a Span without a context using the public ddtrace APIs, the benchmarks need to be updated to reflect real world memory overhead.
Checklist
Reviewer Checklist