Skip to content

chore(mongoengine): remove integration #14173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ddtrace/_monkey.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"kafka": True,
"langgraph": True,
"litellm": True,
"mongoengine": True,
"mysql": True,
"mysqldb": True,
"pymysql": True,
Expand Down
10 changes: 0 additions & 10 deletions ddtrace/contrib/integration_registry/registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -585,16 +585,6 @@ integrations:
min: 1.0.2
max: 1.0.2

- integration_name: mongoengine
is_external_package: true
is_tested: true
dependency_names:
- mongoengine
tested_versions_by_dependency:
mongoengine:
min: 0.23.1
max: 0.29.1

- integration_name: mysql
is_external_package: true
is_tested: true
Expand Down
19 changes: 0 additions & 19 deletions ddtrace/contrib/internal/mongoengine/__init__.py

This file was deleted.

38 changes: 0 additions & 38 deletions ddtrace/contrib/internal/mongoengine/patch.py

This file was deleted.

38 changes: 0 additions & 38 deletions ddtrace/contrib/internal/mongoengine/trace.py

This file was deleted.

1 change: 0 additions & 1 deletion ddtrace/settings/_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@
"aiopg",
"dogpile_cache",
"pylibmc",
"mongoengine",
"httpx",
"httplib",
"rq",
Expand Down
1 change: 0 additions & 1 deletion docs/contributing-integrations.rst
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ are not yet any expected spans stored for it, so we need to create some.

mongo:
- ddtrace/contrib/internal/pymongo/*
- ddtrace/contrib/internal/mongoengine/*
- ddtrace/ext/mongo.py

15. Add a `suite` for your integration in `tests/contrib/suitespec.yml`. This defines test configuration
Expand Down
2 changes: 0 additions & 2 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ contacting support.
+--------------------------------------------------+---------------+----------------+
| :ref:`molten` | >= 1.0 | Yes |
+--------------------------------------------------+---------------+----------------+
| :ref:`mongoengine` | >= 0.23 | Yes |
+--------------------------------------------------+---------------+----------------+
| :ref:`mysql-connector` | >= 8.0.5 | True |
+--------------------------------------------------+---------------+----------------+
| :ref:`mysqldb` | \* | Yes |
Expand Down
7 changes: 0 additions & 7 deletions docs/integrations.rst
Original file line number Diff line number Diff line change
Expand Up @@ -368,13 +368,6 @@ Molten
.. automodule:: ddtrace.contrib.internal.molten


.. _mongoengine:

Mongoengine
^^^^^^^^^^^
.. automodule:: ddtrace.contrib.internal.mongoengine


.. _mysql-connector:

mysql-connector
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
other:
- |
mongoengine: Drops support for the ``ddtrace.Pin`` object with mongoengine. With this change, the ddtrace library no longer directly supports mongoengine.
Mongoengine will be supported through the ``pymongo`` integration.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _is_valid_patch_call(self, tb_string):
"""Checks if the patch call originated from ddtrace.contrib.internal/*/patch.py."""
# reverse the lines to check the most recent patch call first since some integrations call
# other integrations patches:
# e.g. mongoengine calls pymongo's patch
# e.g. django calls postgres's patch
return any(
"ddtrace/contrib/internal" in line and "/patch.py" in line for line in reversed(tb_string.splitlines())
)
Expand Down
Empty file.
Loading
Loading