-
Notifications
You must be signed in to change notification settings - Fork 453
ci: native extension hash cache #13675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 4 ms. The average import time from base is: 281 ± 4 ms. The import time difference between this PR and base is: -2.6 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-18 16:41:27 Comparing candidate commit 940abae in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 559 metrics, 7 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspects-lower_aspect
scenario:iastaspects-swapcase_aspect
scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:telemetryaddmetric-1-gauge-metric-1-times
|
6f2e103
to
51d40bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high level looks good
1318da0
to
b792156
Compare
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build.
b792156
to
475f53f
Compare
b9cc62e
to
f6b4c86
Compare
9cc194d
to
0ce8fda
Compare
0ce8fda
to
74a8c35
Compare
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure ``` .ext_cache/ # Example: └─ <module_name>/ # "ddtrace.profiling.collector" └─ <source_hash>/ # <sha256 hex digest> └─ <binary> # "collector.cpython-310-darwin.so" ``` We implement a custom command to allow retrieving the source to target mapping from `setup.py` directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure ``` .ext_cache/ # Example: └─ <module_name>/ # "ddtrace.profiling.collector" └─ <source_hash>/ # <sha256 hex digest> └─ <binary> # "collector.cpython-310-darwin.so" ``` We implement a custom command to allow retrieving the source to target mapping from `setup.py` directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure ``` .ext_cache/ # Example: └─ <module_name>/ # "ddtrace.profiling.collector" └─ <source_hash>/ # <sha256 hex digest> └─ <binary> # "collector.cpython-310-darwin.so" ``` We implement a custom command to allow retrieving the source to target mapping from `setup.py` directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure ``` .ext_cache/ # Example: └─ <module_name>/ # "ddtrace.profiling.collector" └─ <source_hash>/ # <sha256 hex digest> └─ <binary> # "collector.cpython-310-darwin.so" ``` We implement a custom command to allow retrieving the source to target mapping from `setup.py` directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure ``` .ext_cache/ # Example: └─ <module_name>/ # "ddtrace.profiling.collector" └─ <source_hash>/ # <sha256 hex digest> └─ <binary> # "collector.cpython-310-darwin.so" ``` We implement a custom command to allow retrieving the source to target mapping from `setup.py` directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure
We implement a custom command to allow retrieving the source to target mapping from
setup.py
directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process.Checklist
Reviewer Checklist