-
Notifications
You must be signed in to change notification settings - Fork 440
ci: per-component build cache #13674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
elif args.command == 'check': | ||
should_rebuild = cache.should_rebuild_extension(args.extension) | ||
print(f"Extension {args.extension} should be rebuilt: {should_rebuild}") | ||
exit(0 if not should_rebuild else 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
do not use exit() (...read more)
Use sys.exit()
instead of exit()
. Exit is a builtin and done mostly for the console. sys.exit()
is done for program with a proper return argument (see documentation).
Learn More
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 279 ± 5 ms. The average import time from base is: 281 ± 4 ms. The import time difference between this PR and base is: -1.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
scripts/gen_gitlab_config.py
Outdated
needs: | ||
- job: build_base_venv | ||
artifacts: true | ||
{chr(10).join(f" - job: build_{component}" + chr(10) + " artifacts: true" for component in all_components)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Quality Violation
use f-string or .format to format strings (...read more)
Concatenation of multiple strings is not efficient and make the code hard to read and understand.
Instead of concatenating multiple strings, use an f-string or a format string.
Learn More
BenchmarksBenchmark execution time: 2025-06-16 16:44:42 Comparing candidate commit 0480d38 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 461 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathjoin_aspect
|
Checklist
Reviewer Checklist