-
Notifications
You must be signed in to change notification settings - Fork 167
Add knuth sampling formula #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3281 +/- ##
============================================
- Coverage 75.00% 73.28% -1.73%
Complexity 2969 2969
============================================
Files 119 146 +27
Lines 11685 16134 +4449
Branches 0 1110 +1110
============================================
+ Hits 8764 11823 +3059
- Misses 2921 3734 +813
- Partials 0 577 +577
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-06-11 09:40:37 Comparing candidate commit 875af45 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
This reverts commit 875af45.
This reverts commit 937bd93.
…ated at all Signed-off-by: Bob Weinand <[email protected]>
…_span during sampling" This reverts commit 453e99d.
This reverts commit 0fe9880.
Description
This PR changes the current sampling formula to the one used in every tracer in order to have consistent sampling.
The tracer now applies sampling decisions for distributed traces missing the sampling decision.
Reviewer checklist