Skip to content

Conversation

khanayan123
Copy link
Collaborator

What does this PR do?

When OTEL_LOG_LEVEL='debug', the debug field in the config object should be true

Motivation

Add support for mapping OTEL_LOG_LEVEL='debug' to DD_TRACE_DEBUG=true

Copy link

github-actions bot commented May 30, 2024

Overall package size

Self size: 6.59 MB
Deduped: 61.84 MB
No deduping: 62.12 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@khanayan123 khanayan123 force-pushed the khanayan123/add-otel-env-mapping-for-dd-trace-debug branch from 39f655d to 8e5ac4d Compare May 30, 2024 21:23
@khanayan123 khanayan123 marked this pull request as ready for review May 30, 2024 21:24
@khanayan123 khanayan123 requested a review from a team as a code owner May 30, 2024 21:24
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2024

Benchmarks

Benchmark execution time: 2024-06-03 22:29:55

Comparing candidate commit 1b531a4 in PR branch khanayan123/add-otel-env-mapping-for-dd-trace-debug with baseline commit 60f10dd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the API perspective

@khanayan123 khanayan123 marked this pull request as draft June 3, 2024 21:55
@khanayan123 khanayan123 changed the title An OTEL_LOG_LEVEL of debug should also be mapped to DD_TRACE_DEBUG=true Update Otel Invalid Telemetry Metric Calculation & Support For Mapping OTEL_LOG_LEVEL='debug' Jun 3, 2024
@khanayan123 khanayan123 changed the title Update Otel Invalid Telemetry Metric Calculation & Support For Mapping OTEL_LOG_LEVEL='debug' Add Support For Mapping OTEL_LOG_LEVEL='debug' Jun 3, 2024
@khanayan123 khanayan123 force-pushed the khanayan123/add-otel-env-mapping-for-dd-trace-debug branch from a86b21f to 8e5ac4d Compare June 3, 2024 22:20
@khanayan123 khanayan123 force-pushed the khanayan123/add-otel-env-mapping-for-dd-trace-debug branch from 8e5ac4d to 1b531a4 Compare June 3, 2024 22:21
@khanayan123 khanayan123 marked this pull request as ready for review June 3, 2024 22:21
@khanayan123 khanayan123 merged commit e60feae into master Jun 3, 2024
@khanayan123 khanayan123 deleted the khanayan123/add-otel-env-mapping-for-dd-trace-debug branch June 3, 2024 22:39
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* An OTEL_LOG_LEVEL of debug should also be mapped to  DD_TRACE_DEBUG=true
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* An OTEL_LOG_LEVEL of debug should also be mapped to  DD_TRACE_DEBUG=true
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* An OTEL_LOG_LEVEL of debug should also be mapped to  DD_TRACE_DEBUG=true
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* An OTEL_LOG_LEVEL of debug should also be mapped to  DD_TRACE_DEBUG=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants