-
Notifications
You must be signed in to change notification settings - Fork 311
move armeria modules #9073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
move armeria modules #9073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (998.975 ms) : 0, 998975
Total [baseline] (8.553 s) : 0, 8553070
Agent [candidate] (995.536 ms) : 0, 995536
Total [candidate] (8.543 s) : 0, 8543405
section iast
Agent [baseline] (1.13 s) : 0, 1130229
Total [baseline] (9.272 s) : 0, 9272221
Agent [candidate] (1.129 s) : 0, 1129079
Total [candidate] (9.237 s) : 0, 9237258
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.712 ms) : 0, 691712
BytebuddyAgent [candidate] (687.553 ms) : 0, 687553
GlobalTracer [baseline] (241.262 ms) : 0, 241262
GlobalTracer [candidate] (241.93 ms) : 0, 241930
AppSec [baseline] (30.377 ms) : 0, 30377
AppSec [candidate] (30.331 ms) : 0, 30331
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (674.677 µs) : 0, 675
Remote Config [candidate] (682.099 µs) : 0, 682
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.215 ms) : 0, 8215
section iast
BytebuddyAgent [baseline] (806.695 ms) : 0, 806695
BytebuddyAgent [candidate] (806.193 ms) : 0, 806193
GlobalTracer [baseline] (233.103 ms) : 0, 233103
GlobalTracer [candidate] (232.37 ms) : 0, 232370
IAST [baseline] (26.297 ms) : 0, 26297
IAST [candidate] (27.147 ms) : 0, 27147
AppSec [baseline] (29.128 ms) : 0, 29128
AppSec [candidate] (28.245 ms) : 0, 28245
Debugger [baseline] (5.785 ms) : 0, 5785
Debugger [candidate] (5.815 ms) : 0, 5815
Remote Config [baseline] (574.96 µs) : 0, 575
Remote Config [candidate] (585.362 µs) : 0, 585
Telemetry [baseline] (7.893 ms) : 0, 7893
Telemetry [candidate] (7.956 ms) : 0, 7956
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (994.204 ms) : 0, 994204
Total [baseline] (10.637 s) : 0, 10637198
Agent [candidate] (1.003 s) : 0, 1003496
Total [candidate] (10.619 s) : 0, 10619479
section appsec
Agent [baseline] (1.171 s) : 0, 1171213
Total [baseline] (10.791 s) : 0, 10790827
Agent [candidate] (1.172 s) : 0, 1171942
Total [candidate] (10.721 s) : 0, 10720727
section iast
Agent [baseline] (1.13 s) : 0, 1129890
Total [baseline] (10.811 s) : 0, 10811163
Agent [candidate] (1.145 s) : 0, 1145014
Total [candidate] (10.886 s) : 0, 10886477
section profiling
Agent [baseline] (1.251 s) : 0, 1251166
Total [baseline] (11.002 s) : 0, 11002261
Agent [candidate] (1.25 s) : 0, 1250234
Total [candidate] (10.942 s) : 0, 10942477
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.367 ms) : 0, 686367
BytebuddyAgent [candidate] (692.865 ms) : 0, 692865
GlobalTracer [baseline] (241.876 ms) : 0, 241876
GlobalTracer [candidate] (244.034 ms) : 0, 244034
AppSec [baseline] (30.294 ms) : 0, 30294
AppSec [candidate] (30.624 ms) : 0, 30624
Debugger [baseline] (6.003 ms) : 0, 6003
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (670.021 µs) : 0, 670
Remote Config [candidate] (687.323 µs) : 0, 687
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.325 ms) : 0, 8325
section appsec
BytebuddyAgent [baseline] (708.014 ms) : 0, 708014
BytebuddyAgent [candidate] (709.063 ms) : 0, 709063
GlobalTracer [baseline] (234.903 ms) : 0, 234903
GlobalTracer [candidate] (234.997 ms) : 0, 234997
IAST [baseline] (22.028 ms) : 0, 22028
IAST [candidate] (21.876 ms) : 0, 21876
AppSec [baseline] (170.963 ms) : 0, 170963
AppSec [candidate] (170.824 ms) : 0, 170824
Debugger [baseline] (5.819 ms) : 0, 5819
Debugger [candidate] (5.788 ms) : 0, 5788
Remote Config [baseline] (620.333 µs) : 0, 620
Remote Config [candidate] (601.204 µs) : 0, 601
Telemetry [baseline] (8.14 ms) : 0, 8140
Telemetry [candidate] (8.08 ms) : 0, 8080
section iast
BytebuddyAgent [baseline] (806.705 ms) : 0, 806705
BytebuddyAgent [candidate] (818.284 ms) : 0, 818284
GlobalTracer [baseline] (232.493 ms) : 0, 232493
GlobalTracer [candidate] (234.899 ms) : 0, 234899
IAST [baseline] (27.87 ms) : 0, 27870
IAST [candidate] (29.036 ms) : 0, 29036
AppSec [baseline] (27.73 ms) : 0, 27730
AppSec [candidate] (27.233 ms) : 0, 27233
Debugger [baseline] (5.831 ms) : 0, 5831
Debugger [candidate] (5.855 ms) : 0, 5855
Remote Config [baseline] (595.673 µs) : 0, 596
Remote Config [candidate] (591.009 µs) : 0, 591
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (8.1 ms) : 0, 8100
section profiling
BytebuddyAgent [baseline] (681.518 ms) : 0, 681518
BytebuddyAgent [candidate] (682.288 ms) : 0, 682288
GlobalTracer [baseline] (362.87 ms) : 0, 362870
GlobalTracer [candidate] (362.298 ms) : 0, 362298
AppSec [baseline] (31.896 ms) : 0, 31896
AppSec [candidate] (33.064 ms) : 0, 33064
Debugger [baseline] (10.701 ms) : 0, 10701
Debugger [candidate] (11.166 ms) : 0, 11166
Remote Config [baseline] (667.639 µs) : 0, 668
Remote Config [candidate] (656.421 µs) : 0, 656
Telemetry [baseline] (10.243 ms) : 0, 10243
Telemetry [candidate] (7.991 ms) : 0, 7991
ProfilingAgent [baseline] (104.451 ms) : 0, 104451
ProfilingAgent [candidate] (103.84 ms) : 0, 103840
Profiling [baseline] (104.475 ms) : 0, 104475
Profiling [candidate] (103.864 ms) : 0, 103864
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (4.264 ms) : 4204, 4323
. : milestone, 4264,
iast (9.252 ms) : 9098, 9405
. : milestone, 9252,
iast_FULL (13.683 ms) : 13414, 13952
. : milestone, 13683,
iast_GLOBAL (10.14 ms) : 9961, 10319
. : milestone, 10140,
profiling (8.58 ms) : 8443, 8717
. : milestone, 8580,
tracing (7.559 ms) : 7451, 7666
. : milestone, 7559,
section candidate
no_agent (4.416 ms) : 4362, 4470
. : milestone, 4416,
iast (9.281 ms) : 9129, 9434
. : milestone, 9281,
iast_FULL (13.939 ms) : 13664, 14214
. : milestone, 13939,
iast_GLOBAL (10.063 ms) : 9880, 10247
. : milestone, 10063,
profiling (8.728 ms) : 8586, 8870
. : milestone, 8728,
tracing (7.605 ms) : 7491, 7718
. : milestone, 7605,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (37.796 ms) : 37490, 38103
. : milestone, 37796,
appsec (47.836 ms) : 47402, 48269
. : milestone, 47836,
code_origins (44.905 ms) : 44514, 45296
. : milestone, 44905,
iast (44.259 ms) : 43868, 44651
. : milestone, 44259,
profiling (49.419 ms) : 48957, 49880
. : milestone, 49419,
tracing (43.358 ms) : 42998, 43717
. : milestone, 43358,
section candidate
no_agent (36.279 ms) : 35975, 36584
. : milestone, 36279,
appsec (48.89 ms) : 48454, 49326
. : milestone, 48890,
code_origins (46.719 ms) : 46313, 47125
. : milestone, 46719,
iast (44.926 ms) : 44519, 45333
. : milestone, 44926,
profiling (45.733 ms) : 45282, 46184
. : milestone, 45733,
tracing (44.039 ms) : 43658, 44420
. : milestone, 44039,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.397 ms) : 2348, 2446
. : milestone, 2397,
iast (2.185 ms) : 2123, 2248
. : milestone, 2185,
iast_GLOBAL (2.224 ms) : 2161, 2286
. : milestone, 2224,
profiling (2.029 ms) : 1980, 2079
. : milestone, 2029,
tracing (2.004 ms) : 1956, 2052
. : milestone, 2004,
section candidate
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (2.394 ms) : 2345, 2443
. : milestone, 2394,
iast (2.186 ms) : 2124, 2248
. : milestone, 2186,
iast_GLOBAL (2.227 ms) : 2165, 2290
. : milestone, 2227,
profiling (2.02 ms) : 1970, 2069
. : milestone, 2020,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~93630f5769, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
appsec (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
iast (18.402 s) : 18402000, 18402000
. : milestone, 18402000,
iast_GLOBAL (17.993 s) : 17993000, 17993000
. : milestone, 17993000,
profiling (15.321 s) : 15321000, 15321000
. : milestone, 15321000,
tracing (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
section candidate
no_agent (15.385 s) : 15385000, 15385000
. : milestone, 15385000,
appsec (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
iast (18.357 s) : 18357000, 18357000
. : milestone, 18357000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
. : milestone, 17972000,
profiling (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
tracing (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
|
81f4335
to
4e72c7f
Compare
PerfectSlayer
approved these changes
Jul 2, 2025
bric3
approved these changes
Jul 2, 2025
098e36d
to
93630f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: armeria
Armeria Instrumentation
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactor armeria gradle modules according to new guidelines
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]