-
Notifications
You must be signed in to change notification settings - Fork 311
Disable legacy Gitlab exec in order to fix jobs failing with green status #9066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
dc18769
to
888e597
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (998.4 ms) : 0, 998400
Total [baseline] (8.567 s) : 0, 8567432
Agent [candidate] (996.154 ms) : 0, 996154
Total [candidate] (8.549 s) : 0, 8549286
section iast
Agent [baseline] (1.133 s) : 0, 1132995
Total [baseline] (9.269 s) : 0, 9269450
Agent [candidate] (1.135 s) : 0, 1135262
Total [candidate] (9.295 s) : 0, 9294566
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.135 ms) : 0, 689135
BytebuddyAgent [candidate] (687.705 ms) : 0, 687705
GlobalTracer [baseline] (242.36 ms) : 0, 242360
GlobalTracer [candidate] (242.376 ms) : 0, 242376
AppSec [baseline] (30.404 ms) : 0, 30404
AppSec [candidate] (30.4 ms) : 0, 30400
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (673.634 µs) : 0, 674
Remote Config [candidate] (681.111 µs) : 0, 681
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.158 ms) : 0, 8158
section iast
BytebuddyAgent [baseline] (808.601 ms) : 0, 808601
BytebuddyAgent [candidate] (810.698 ms) : 0, 810698
GlobalTracer [baseline] (233.452 ms) : 0, 233452
GlobalTracer [candidate] (233.475 ms) : 0, 233475
AppSec [baseline] (27.791 ms) : 0, 27791
AppSec [candidate] (26.955 ms) : 0, 26955
Debugger [baseline] (5.838 ms) : 0, 5838
Debugger [candidate] (5.832 ms) : 0, 5832
Remote Config [baseline] (598.161 µs) : 0, 598
Remote Config [candidate] (598.606 µs) : 0, 599
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.009 ms) : 0, 8009
IAST [baseline] (27.886 ms) : 0, 27886
IAST [candidate] (28.915 ms) : 0, 28915
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1008709
Total [baseline] (10.685 s) : 0, 10684901
Agent [candidate] (997.568 ms) : 0, 997568
Total [candidate] (10.73 s) : 0, 10730050
section appsec
Agent [baseline] (1.175 s) : 0, 1174524
Total [baseline] (10.778 s) : 0, 10778248
Agent [candidate] (1.174 s) : 0, 1173724
Total [candidate] (10.723 s) : 0, 10722772
section iast
Agent [baseline] (1.134 s) : 0, 1134050
Total [baseline] (10.856 s) : 0, 10855610
Agent [candidate] (1.133 s) : 0, 1133238
Total [candidate] (10.912 s) : 0, 10911838
section profiling
Agent [baseline] (1.248 s) : 0, 1248460
Total [baseline] (10.957 s) : 0, 10957268
Agent [candidate] (1.254 s) : 0, 1253902
Total [candidate] (10.934 s) : 0, 10933872
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.752 ms) : 0, 696752
BytebuddyAgent [candidate] (688.567 ms) : 0, 688567
GlobalTracer [baseline] (245.001 ms) : 0, 245001
GlobalTracer [candidate] (242.306 ms) : 0, 242306
AppSec [baseline] (30.716 ms) : 0, 30716
AppSec [candidate] (30.258 ms) : 0, 30258
Debugger [baseline] (6.123 ms) : 0, 6123
Debugger [candidate] (6.031 ms) : 0, 6031
Remote Config [baseline] (694.722 µs) : 0, 695
Remote Config [candidate] (680.288 µs) : 0, 680
Telemetry [baseline] (8.298 ms) : 0, 8298
Telemetry [candidate] (8.914 ms) : 0, 8914
section appsec
BytebuddyAgent [baseline] (710.737 ms) : 0, 710737
BytebuddyAgent [candidate] (709.997 ms) : 0, 709997
GlobalTracer [baseline] (235.286 ms) : 0, 235286
GlobalTracer [candidate] (235.603 ms) : 0, 235603
AppSec [baseline] (171.211 ms) : 0, 171211
AppSec [candidate] (170.931 ms) : 0, 170931
Debugger [baseline] (5.773 ms) : 0, 5773
Debugger [candidate] (5.773 ms) : 0, 5773
Remote Config [baseline] (610.679 µs) : 0, 611
Remote Config [candidate] (614.483 µs) : 0, 614
Telemetry [baseline] (8.048 ms) : 0, 8048
Telemetry [candidate] (8.105 ms) : 0, 8105
IAST [baseline] (22.062 ms) : 0, 22062
IAST [candidate] (21.951 ms) : 0, 21951
section iast
BytebuddyAgent [baseline] (809.453 ms) : 0, 809453
BytebuddyAgent [candidate] (808.749 ms) : 0, 808749
GlobalTracer [baseline] (233.789 ms) : 0, 233789
GlobalTracer [candidate] (233.11 ms) : 0, 233110
AppSec [baseline] (26.811 ms) : 0, 26811
AppSec [candidate] (27.868 ms) : 0, 27868
Debugger [baseline] (5.842 ms) : 0, 5842
Debugger [candidate] (5.88 ms) : 0, 5880
Remote Config [baseline] (592.674 µs) : 0, 593
Remote Config [candidate] (590.465 µs) : 0, 590
Telemetry [baseline] (8.017 ms) : 0, 8017
Telemetry [candidate] (8.054 ms) : 0, 8054
IAST [baseline] (28.715 ms) : 0, 28715
IAST [candidate] (28.103 ms) : 0, 28103
section profiling
BytebuddyAgent [baseline] (680.403 ms) : 0, 680403
BytebuddyAgent [candidate] (684.056 ms) : 0, 684056
GlobalTracer [baseline] (362.632 ms) : 0, 362632
GlobalTracer [candidate] (364.479 ms) : 0, 364479
AppSec [baseline] (32.406 ms) : 0, 32406
AppSec [candidate] (32.625 ms) : 0, 32625
Debugger [baseline] (12.045 ms) : 0, 12045
Debugger [candidate] (9.911 ms) : 0, 9911
Remote Config [baseline] (681.785 µs) : 0, 682
Remote Config [candidate] (660.485 µs) : 0, 660
Telemetry [baseline] (8.057 ms) : 0, 8057
Telemetry [candidate] (10.224 ms) : 0, 10224
ProfilingAgent [baseline] (103.661 ms) : 0, 103661
ProfilingAgent [candidate] (102.931 ms) : 0, 102931
Profiling [baseline] (103.685 ms) : 0, 103685
Profiling [candidate] (102.956 ms) : 0, 102956
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section baseline
no_agent (4.291 ms) : 4243, 4339
. : milestone, 4291,
iast (9.01 ms) : 8866, 9155
. : milestone, 9010,
iast_FULL (13.646 ms) : 13377, 13915
. : milestone, 13646,
iast_GLOBAL (10.108 ms) : 9928, 10287
. : milestone, 10108,
profiling (8.889 ms) : 8748, 9031
. : milestone, 8889,
tracing (7.433 ms) : 7328, 7539
. : milestone, 7433,
section candidate
no_agent (4.302 ms) : 4249, 4355
. : milestone, 4302,
iast (9.169 ms) : 9017, 9321
. : milestone, 9169,
iast_FULL (13.751 ms) : 13476, 14025
. : milestone, 13751,
iast_GLOBAL (10.118 ms) : 9937, 10299
. : milestone, 10118,
profiling (8.782 ms) : 8648, 8916
. : milestone, 8782,
tracing (7.538 ms) : 7431, 7646
. : milestone, 7538,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section baseline
no_agent (36.178 ms) : 35888, 36467
. : milestone, 36178,
appsec (47.141 ms) : 46715, 47566
. : milestone, 47141,
code_origins (45.197 ms) : 44809, 45584
. : milestone, 45197,
iast (44.084 ms) : 43700, 44468
. : milestone, 44084,
profiling (48.386 ms) : 47934, 48837
. : milestone, 48386,
tracing (44.406 ms) : 44038, 44774
. : milestone, 44406,
section candidate
no_agent (38.189 ms) : 37885, 38493
. : milestone, 38189,
appsec (46.164 ms) : 45747, 46580
. : milestone, 46164,
code_origins (43.822 ms) : 43439, 44206
. : milestone, 43822,
iast (44.061 ms) : 43685, 44436
. : milestone, 44061,
profiling (47.501 ms) : 47047, 47955
. : milestone, 47501,
tracing (43.255 ms) : 42881, 43629
. : milestone, 43255,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section baseline
no_agent (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
appsec (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
iast (18.495 s) : 18495000, 18495000
. : milestone, 18495000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
section candidate
no_agent (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
appsec (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
iast (18.683 s) : 18683000, 18683000
. : milestone, 18683000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
tracing (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~888e597ee1, baseline=1.51.0-SNAPSHOT~0f66a88142
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.411 ms) : 2362, 2460
. : milestone, 2411,
iast (2.19 ms) : 2129, 2252
. : milestone, 2190,
iast_GLOBAL (2.225 ms) : 2163, 2287
. : milestone, 2225,
profiling (2.055 ms) : 2003, 2106
. : milestone, 2055,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
section candidate
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (2.42 ms) : 2370, 2470
. : milestone, 2420,
iast (2.2 ms) : 2138, 2262
. : milestone, 2200,
iast_GLOBAL (2.235 ms) : 2172, 2297
. : milestone, 2235,
profiling (2.051 ms) : 2000, 2102
. : milestone, 2051,
tracing (2.0 ms) : 1953, 2048
. : milestone, 2000,
|
What Does This Do
Disables FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY that we used before to ensure build containers have QoS guaranteed. As of now, it doesn't seem to be necessary anymore, but leads to problems like https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119.
Example failing jobs:
Motivation
Fix benchmarking jobs that silently fail with green status.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]