-
Notifications
You must be signed in to change notification settings - Fork 311
Convert some build file to kotlin dsl #8743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.477 ms) : 0, 997477
Total [baseline] (8.583 s) : 0, 8583020
Agent [candidate] (1.002 s) : 0, 1001967
Total [candidate] (8.652 s) : 0, 8652474
section iast
Agent [baseline] (1.128 s) : 0, 1128163
Total [baseline] (9.253 s) : 0, 9253143
Agent [candidate] (1.129 s) : 0, 1128927
Total [candidate] (9.267 s) : 0, 9267041
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.743 ms) : 0, 688743
BytebuddyAgent [candidate] (691.768 ms) : 0, 691768
GlobalTracer [baseline] (242.587 ms) : 0, 242587
GlobalTracer [candidate] (243.77 ms) : 0, 243770
AppSec [baseline] (30.214 ms) : 0, 30214
AppSec [candidate] (30.412 ms) : 0, 30412
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (668.701 µs) : 0, 669
Remote Config [candidate] (666.156 µs) : 0, 666
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.267 ms) : 0, 8267
section iast
BytebuddyAgent [baseline] (805.668 ms) : 0, 805668
BytebuddyAgent [candidate] (806.422 ms) : 0, 806422
GlobalTracer [baseline] (232.368 ms) : 0, 232368
GlobalTracer [candidate] (232.196 ms) : 0, 232196
AppSec [baseline] (27.631 ms) : 0, 27631
AppSec [candidate] (29.321 ms) : 0, 29321
Debugger [baseline] (5.754 ms) : 0, 5754
Debugger [candidate] (5.758 ms) : 0, 5758
Remote Config [baseline] (577.29 µs) : 0, 577
Remote Config [candidate] (577.199 µs) : 0, 577
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.886 ms) : 0, 7886
IAST [baseline] (27.522 ms) : 0, 27522
IAST [candidate] (26.01 ms) : 0, 26010
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.796 ms) : 0, 993796
Total [baseline] (10.617 s) : 0, 10617088
Agent [candidate] (994.219 ms) : 0, 994219
Total [candidate] (10.747 s) : 0, 10746781
section appsec
Agent [baseline] (1.173 s) : 0, 1173446
Total [baseline] (10.707 s) : 0, 10707493
Agent [candidate] (1.18 s) : 0, 1179952
Total [candidate] (10.76 s) : 0, 10759521
section iast
Agent [baseline] (1.127 s) : 0, 1126900
Total [baseline] (10.796 s) : 0, 10796253
Agent [candidate] (1.129 s) : 0, 1129301
Total [candidate] (10.867 s) : 0, 10866769
section profiling
Agent [baseline] (1.244 s) : 0, 1243758
Total [baseline] (11.024 s) : 0, 11024299
Agent [candidate] (1.241 s) : 0, 1240810
Total [candidate] (11.028 s) : 0, 11028464
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.958 ms) : 0, 685958
BytebuddyAgent [candidate] (685.715 ms) : 0, 685715
GlobalTracer [baseline] (242.136 ms) : 0, 242136
GlobalTracer [candidate] (242.387 ms) : 0, 242387
AppSec [baseline] (30.002 ms) : 0, 30002
AppSec [candidate] (30.224 ms) : 0, 30224
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (652.411 µs) : 0, 652
Remote Config [candidate] (680.728 µs) : 0, 681
Telemetry [baseline] (8.091 ms) : 0, 8091
Telemetry [candidate] (8.185 ms) : 0, 8185
section appsec
BytebuddyAgent [baseline] (710.74 ms) : 0, 710740
BytebuddyAgent [candidate] (714.435 ms) : 0, 714435
GlobalTracer [baseline] (235.961 ms) : 0, 235961
GlobalTracer [candidate] (237.337 ms) : 0, 237337
IAST [baseline] (21.848 ms) : 0, 21848
IAST [candidate] (22.173 ms) : 0, 22173
AppSec [baseline] (169.451 ms) : 0, 169451
AppSec [candidate] (170.27 ms) : 0, 170270
Debugger [baseline] (5.822 ms) : 0, 5822
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (612.296 µs) : 0, 612
Remote Config [candidate] (616.855 µs) : 0, 617
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.271 ms) : 0, 8271
section iast
BytebuddyAgent [baseline] (805.107 ms) : 0, 805107
BytebuddyAgent [candidate] (806.555 ms) : 0, 806555
GlobalTracer [baseline] (231.787 ms) : 0, 231787
GlobalTracer [candidate] (232.36 ms) : 0, 232360
IAST [baseline] (25.129 ms) : 0, 25129
IAST [candidate] (27.06 ms) : 0, 27060
AppSec [baseline] (29.842 ms) : 0, 29842
AppSec [candidate] (28.346 ms) : 0, 28346
Debugger [baseline] (5.732 ms) : 0, 5732
Debugger [candidate] (5.76 ms) : 0, 5760
Remote Config [baseline] (584.701 µs) : 0, 585
Remote Config [candidate] (562.347 µs) : 0, 562
Telemetry [baseline] (7.851 ms) : 0, 7851
Telemetry [candidate] (7.865 ms) : 0, 7865
section profiling
BytebuddyAgent [baseline] (678.478 ms) : 0, 678478
BytebuddyAgent [candidate] (676.828 ms) : 0, 676828
GlobalTracer [baseline] (361.871 ms) : 0, 361871
GlobalTracer [candidate] (360.783 ms) : 0, 360783
AppSec [baseline] (31.442 ms) : 0, 31442
AppSec [candidate] (30.592 ms) : 0, 30592
Debugger [baseline] (10.359 ms) : 0, 10359
Debugger [candidate] (8.923 ms) : 0, 8923
Remote Config [baseline] (656.803 µs) : 0, 657
Remote Config [candidate] (667.536 µs) : 0, 668
Telemetry [baseline] (10.124 ms) : 0, 10124
Telemetry [candidate] (11.546 ms) : 0, 11546
ProfilingAgent [baseline] (102.162 ms) : 0, 102162
ProfilingAgent [candidate] (102.892 ms) : 0, 102892
Profiling [baseline] (102.187 ms) : 0, 102187
Profiling [candidate] (102.918 ms) : 0, 102918
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (37.338 ms) : 37041, 37635
. : milestone, 37338,
appsec (47.384 ms) : 46972, 47795
. : milestone, 47384,
code_origins (45.984 ms) : 45597, 46371
. : milestone, 45984,
iast (43.83 ms) : 43452, 44207
. : milestone, 43830,
profiling (47.363 ms) : 46882, 47843
. : milestone, 47363,
tracing (45.127 ms) : 44746, 45507
. : milestone, 45127,
section candidate
no_agent (37.655 ms) : 37352, 37957
. : milestone, 37655,
appsec (45.276 ms) : 44864, 45688
. : milestone, 45276,
code_origins (44.418 ms) : 44045, 44792
. : milestone, 44418,
iast (45.076 ms) : 44696, 45455
. : milestone, 45076,
profiling (49.806 ms) : 49311, 50300
. : milestone, 49806,
tracing (44.985 ms) : 44598, 45372
. : milestone, 44985,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (4.506 ms) : 4454, 4558
. : milestone, 4506,
iast (9.435 ms) : 9274, 9596
. : milestone, 9435,
iast_FULL (13.92 ms) : 13648, 14192
. : milestone, 13920,
iast_GLOBAL (10.173 ms) : 9993, 10353
. : milestone, 10173,
profiling (8.581 ms) : 8449, 8712
. : milestone, 8581,
tracing (7.461 ms) : 7358, 7564
. : milestone, 7461,
section candidate
no_agent (4.18 ms) : 4134, 4226
. : milestone, 4180,
iast (9.176 ms) : 9030, 9322
. : milestone, 9176,
iast_FULL (13.732 ms) : 13463, 14002
. : milestone, 13732,
iast_GLOBAL (10.204 ms) : 10027, 10381
. : milestone, 10204,
profiling (8.716 ms) : 8585, 8847
. : milestone, 8716,
tracing (7.657 ms) : 7548, 7766
. : milestone, 7657,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.588 s) : 18588000, 18588000
. : milestone, 18588000,
iast_GLOBAL (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
profiling (15.812 s) : 15812000, 15812000
. : milestone, 15812000,
tracing (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
section candidate
no_agent (15.451 s) : 15451000, 15451000
. : milestone, 15451000,
appsec (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
iast (18.26 s) : 18260000, 18260000
. : milestone, 18260000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ecf4b5736, baseline=1.51.0-SNAPSHOT~c5581eae59
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.407 ms) : 2358, 2455
. : milestone, 2407,
iast (2.191 ms) : 2130, 2253
. : milestone, 2191,
iast_GLOBAL (2.227 ms) : 2166, 2288
. : milestone, 2227,
profiling (2.052 ms) : 2002, 2102
. : milestone, 2052,
tracing (2.014 ms) : 1967, 2062
. : milestone, 2014,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (2.409 ms) : 2361, 2458
. : milestone, 2409,
iast (2.195 ms) : 2133, 2256
. : milestone, 2195,
iast_GLOBAL (2.243 ms) : 2181, 2304
. : milestone, 2243,
profiling (2.05 ms) : 2001, 2100
. : milestone, 2050,
tracing (2.017 ms) : 1969, 2065
. : milestone, 2017,
|
84f5501
to
91c831a
Compare
91c831a
to
5119b96
Compare
5119b96
to
e78114c
Compare
5e42693
to
3909acc
Compare
3909acc
to
ba255b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring! 👍
Left few comments
|
||
plugins { | ||
`java-library` | ||
idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this one have idea
specifically enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to force the jdk to 17 for this module. It was used before.
In order to not break anything at this point, so I kept the configuration. We can revisit this later.
In the meantime, load benchmark is totally flaky:
|
…uild-to-kotlin-dsl
What Does This Do
Converts the build.gradle to build.gradle.kts
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]