Nikita tkachenko/test env 6a2bd8d1ecc54c7c918efdbd1e62027619269fc2 #8497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(core): Clean up old propagation API * feat(core): Refactor disabled tracing propagator
…ives (#8462) Excluded by the iast instrumenter com.azure.core.amqp.ExponentialAmqpRetryPolicy com.azure.core.util.CoreUtils com.azure.cosmos.implementation.directconnectivity.GoneAndRetryWithRetryPolicy$RetryWithRetryPolicy com.azure.cosmos.implementation.directconnectivity.StoreReader com.azure.cosmos.implementation.directconnectivity.addressEnumerator.AddressEnumeratorUsingPermutations com.azure.cosmos.implementation.uuid.UUIDTimer com.azure.messaging.eventhubs.EventProcessorClient com.azure.messaging.eventhubs.PartitionBasedLoadBalancer com.launchdarkly.shaded.com.launchdarkly.eventsource.EventSource com.microsoft.sqlserver.jdbc.SQLServerConnection
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -51,8 +52,7 @@ public class HttpCodec { | |||
| static final String CF_CONNECTING_IP_V6_KEY = "cf-connecting-ipv6"; | |||
|
|
|||
| public interface Injector { | |||
| <C> void inject( | |||
| final DDSpanContext context, final C carrier, final AgentPropagation.Setter<C> setter); | |||
| <C> void inject(final DDSpanContext context, final C carrier, final CarrierSetter<C> setter); | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| <C> void inject(final DDSpanContext context, final C carrier, final CarrierSetter<C> setter); | |
| <C> void inject(final DDSpanContext context, final C carrier, CarrierSetter<C> setter); |
Avoid declaring as final as it may not be used (...read more)
The rule "Avoid useless final type in interface method" advises against the unnecessary use of the final keyword in the method parameters of an interface. In Java, the final keyword is used to denote that a variable cannot be changed once assigned. However, in the context of an interface method, this is redundant as the value of the parameter cannot be changed within the method anyway.
The importance of this rule lies in the clarity and simplicity of code. Unnecessary use of final in this context can lead to confusion for those reading the code, as it suggests that there may be a specific reason for its use when there is not. It can also clutter the code, making it less readable.
Good coding practices to avoid this rule violation include simply not using the final keyword in the method parameters of an interface. This does not affect the functionality of the code, but it makes it cleaner and easier to understand. For example, instead of writing void process(final Object arg);, you can write void process(Object arg);. This maintains the same functionality but improves the readability of the code.
BenchmarksStartupParameters
See matching parameters
SummaryFound 21 performance improvements and 5 performance regressions! Performance is the same for 27 metrics, 10 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.132 s) : 0, 1132419
Total [baseline] (11.508 s) : 0, 11508253
Agent [candidate] (1.041 s) : 0, 1040747
Total [candidate] (10.456 s) : 0, 10455522
section appsec
Agent [baseline] (1.275 s) : 0, 1275284
Total [baseline] (11.636 s) : 0, 11636166
Agent [candidate] (1.182 s) : 0, 1181580
Total [candidate] (10.701 s) : 0, 10700960
section iast
Agent [baseline] (1.267 s) : 0, 1267444
Total [baseline] (11.912 s) : 0, 11912454
Agent [candidate] (1.171 s) : 0, 1171198
Total [candidate] (10.931 s) : 0, 10930801
section profiling
Agent [baseline] (1.387 s) : 0, 1386688
Total [baseline] (11.732 s) : 0, 11732112
Agent [candidate] (1.265 s) : 0, 1264732
Total [candidate] (10.86 s) : 0, 10860138
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.741 ms) : 0, 714741
BytebuddyAgent [candidate] (716.944 ms) : 0, 716944
GlobalTracer [baseline] (238.93 ms) : 0, 238930
GlobalTracer [candidate] (239.266 ms) : 0, 239266
AppSec [baseline] (55.669 ms) : 0, 55669
AppSec [candidate] (55.708 ms) : 0, 55708
Remote Config [baseline] (591.598 µs) : 0, 592
Remote Config [candidate] (699.828 µs) : 0, 700
Telemetry [baseline] (12.446 ms) : 0, 12446
Telemetry [candidate] (13.148 ms) : 0, 13148
Debugger [baseline] (95.096 ms) : 0, 95096
section appsec
BytebuddyAgent [baseline] (737.21 ms) : 0, 737210
BytebuddyAgent [candidate] (734.572 ms) : 0, 734572
GlobalTracer [baseline] (237.156 ms) : 0, 237156
GlobalTracer [candidate] (235.61 ms) : 0, 235610
IAST [baseline] (21.791 ms) : 0, 21791
IAST [candidate] (21.599 ms) : 0, 21599
AppSec [baseline] (177.521 ms) : 0, 177521
AppSec [candidate] (176.74 ms) : 0, 176740
Remote Config [baseline] (638.699 µs) : 0, 639
Remote Config [candidate] (652.571 µs) : 0, 653
Telemetry [baseline] (12.277 ms) : 0, 12277
Telemetry [candidate] (8.258 ms) : 0, 8258
Debugger [baseline] (84.534 ms) : 0, 84534
section iast
BytebuddyAgent [baseline] (842.185 ms) : 0, 842185
BytebuddyAgent [candidate] (836.48 ms) : 0, 836480
GlobalTracer [baseline] (231.474 ms) : 0, 231474
GlobalTracer [candidate] (230.134 ms) : 0, 230134
IAST [baseline] (23.817 ms) : 0, 23817
IAST [candidate] (22.862 ms) : 0, 22862
AppSec [baseline] (56.601 ms) : 0, 56601
AppSec [candidate] (57.336 ms) : 0, 57336
Remote Config [baseline] (514.675 µs) : 0, 515
Remote Config [candidate] (606.133 µs) : 0, 606
Telemetry [baseline] (13.664 ms) : 0, 13664
Telemetry [candidate] (8.766 ms) : 0, 8766
Debugger [baseline] (84.007 ms) : 0, 84007
section profiling
BytebuddyAgent [baseline] (713.159 ms) : 0, 713159
BytebuddyAgent [candidate] (711.424 ms) : 0, 711424
GlobalTracer [baseline] (351.537 ms) : 0, 351537
GlobalTracer [candidate] (351.791 ms) : 0, 351791
AppSec [baseline] (55.854 ms) : 0, 55854
AppSec [candidate] (54.831 ms) : 0, 54831
Remote Config [baseline] (606.958 µs) : 0, 607
Remote Config [candidate] (669.63 µs) : 0, 670
Telemetry [baseline] (12.633 ms) : 0, 12633
Telemetry [candidate] (9.089 ms) : 0, 9089
Debugger [baseline] (88.724 ms) : 0, 88724
ProfilingAgent [baseline] (123.513 ms) : 0, 123513
ProfilingAgent [candidate] (96.514 ms) : 0, 96514
Profiling [baseline] (123.535 ms) : 0, 123535
Profiling [candidate] (96.538 ms) : 0, 96538
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.139 s) : 0, 1138528
Total [baseline] (9.27 s) : 0, 9270192
Agent [candidate] (1.038 s) : 0, 1038459
Total [candidate] (8.648 s) : 0, 8648029
section iast
Agent [baseline] (1.253 s) : 0, 1253132
Total [baseline] (9.838 s) : 0, 9837976
Agent [candidate] (1.174 s) : 0, 1173985
Total [candidate] (9.21 s) : 0, 9209670
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.272 s) : 0, 1271691
Total [baseline] (9.815 s) : 0, 9815403
Agent [candidate] (1.178 s) : 0, 1178263
Total [candidate] (9.193 s) : 0, 9192543
section iast_TELEMETRY_OFF
Agent [baseline] (1.26 s) : 0, 1259752
Total [baseline] (9.878 s) : 0, 9878110
Agent [candidate] (1.167 s) : 0, 1166665
Total [candidate] (9.208 s) : 0, 9208240
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.616 ms) : 0, 718616
BytebuddyAgent [candidate] (716.039 ms) : 0, 716039
GlobalTracer [baseline] (240.463 ms) : 0, 240463
GlobalTracer [candidate] (238.37 ms) : 0, 238370
AppSec [baseline] (55.588 ms) : 0, 55588
AppSec [candidate] (55.535 ms) : 0, 55535
Remote Config [baseline] (588.466 µs) : 0, 588
Remote Config [candidate] (686.743 µs) : 0, 687
Telemetry [baseline] (12.549 ms) : 0, 12549
Telemetry [candidate] (12.951 ms) : 0, 12951
Debugger [baseline] (95.693 ms) : 0, 95693
section iast
BytebuddyAgent [baseline] (832.695 ms) : 0, 832695
BytebuddyAgent [candidate] (840.112 ms) : 0, 840112
GlobalTracer [baseline] (229.834 ms) : 0, 229834
GlobalTracer [candidate] (229.912 ms) : 0, 229912
IAST [baseline] (22.692 ms) : 0, 22692
IAST [candidate] (22.839 ms) : 0, 22839
AppSec [baseline] (56.961 ms) : 0, 56961
AppSec [candidate] (56.733 ms) : 0, 56733
Remote Config [baseline] (512.738 µs) : 0, 513
Remote Config [candidate] (619.613 µs) : 0, 620
Telemetry [baseline] (12.86 ms) : 0, 12860
Telemetry [candidate] (8.705 ms) : 0, 8705
Debugger [baseline] (82.672 ms) : 0, 82672
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (844.283 ms) : 0, 844283
BytebuddyAgent [candidate] (842.318 ms) : 0, 842318
GlobalTracer [baseline] (232.612 ms) : 0, 232612
GlobalTracer [candidate] (230.9 ms) : 0, 230900
IAST [baseline] (23.255 ms) : 0, 23255
IAST [candidate] (22.935 ms) : 0, 22935
AppSec [baseline] (57.965 ms) : 0, 57965
AppSec [candidate] (57.624 ms) : 0, 57624
Remote Config [baseline] (530.73 µs) : 0, 531
Remote Config [candidate] (611.948 µs) : 0, 612
Telemetry [baseline] (13.78 ms) : 0, 13780
Telemetry [candidate] (8.803 ms) : 0, 8803
Debugger [baseline] (84.147 ms) : 0, 84147
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.572 ms) : 0, 837572
BytebuddyAgent [candidate] (833.52 ms) : 0, 833520
GlobalTracer [baseline] (230.981 ms) : 0, 230981
GlobalTracer [candidate] (229.864 ms) : 0, 229864
IAST [baseline] (23.283 ms) : 0, 23283
IAST [candidate] (24.657 ms) : 0, 24657
AppSec [baseline] (56.371 ms) : 0, 56371
AppSec [candidate] (54.474 ms) : 0, 54474
Remote Config [baseline] (526.68 µs) : 0, 527
Remote Config [candidate] (605.296 µs) : 0, 605
Telemetry [baseline] (12.166 ms) : 0, 12166
Telemetry [candidate] (8.548 ms) : 0, 8548
Debugger [baseline] (83.714 ms) : 0, 83714
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1351, 1393
. : milestone, 1372,
appsec (1.735 ms) : 1710, 1760
. : milestone, 1735,
appsec_no_iast (1.714 ms) : 1690, 1739
. : milestone, 1714,
code_origins (1.706 ms) : 1673, 1738
. : milestone, 1706,
iast (1.518 ms) : 1493, 1544
. : milestone, 1518,
profiling (1.558 ms) : 1522, 1595
. : milestone, 1558,
tracing (1.496 ms) : 1473, 1520
. : milestone, 1496,
section candidate
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.755 ms) : 1731, 1778
. : milestone, 1755,
appsec_no_iast (1.731 ms) : 1706, 1757
. : milestone, 1731,
code_origins (1.668 ms) : 1634, 1702
. : milestone, 1668,
iast (1.506 ms) : 1482, 1530
. : milestone, 1506,
profiling (1.5 ms) : 1476, 1524
. : milestone, 1500,
tracing (1.49 ms) : 1465, 1514
. : milestone, 1490,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (390.338 µs) : 370, 410
. : milestone, 390,
iast (516.403 µs) : 492, 541
. : milestone, 516,
iast_FULL (732.748 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (560.154 µs) : 538, 582
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (514.01 µs) : 492, 536
. : milestone, 514,
iast_INACTIVE (456.367 µs) : 435, 478
. : milestone, 456,
iast_TELEMETRY_OFF (510.258 µs) : 487, 533
. : milestone, 510,
tracing (451.748 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (372.528 µs) : 353, 392
. : milestone, 373,
iast (512.211 µs) : 489, 535
. : milestone, 512,
iast_FULL (724.308 µs) : 702, 747
. : milestone, 724,
iast_GLOBAL (552.747 µs) : 531, 574
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (511.017 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (464.752 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (501.333 µs) : 478, 525
. : milestone, 501,
tracing (451.161 µs) : 430, 472
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
appsec (15.259 s) : 15259000, 15259000
. : milestone, 15259000,
iast (18.893 s) : 18893000, 18893000
. : milestone, 18893000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
. : milestone, 18001000,
profiling (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
section candidate
no_agent (15.586 s) : 15586000, 15586000
. : milestone, 15586000,
appsec (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
iast (18.649 s) : 18649000, 18649000
. : milestone, 18649000,
iast_GLOBAL (18.031 s) : 18031000, 18031000
. : milestone, 18031000,
profiling (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
tracing (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6a2bd8d1ec, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.338 ms) : 2295, 2382
. : milestone, 2338,
iast (2.123 ms) : 2068, 2178
. : milestone, 2123,
iast_GLOBAL (2.162 ms) : 2107, 2218
. : milestone, 2162,
profiling (1.965 ms) : 1921, 2008
. : milestone, 1965,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.337 ms) : 2294, 2380
. : milestone, 2337,
iast (2.119 ms) : 2063, 2174
. : milestone, 2119,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (1.973 ms) : 1929, 2018
. : milestone, 1973,
tracing (1.952 ms) : 1910, 1995
. : milestone, 1952,
|
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/test-env-6a2bd8d1ecc54c7c918efdbd1e62027619269fc2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]