Skip to content

feat: bump minimum Go version to 1.24 #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 21, 2025
Merged

feat: bump minimum Go version to 1.24 #3875

merged 10 commits into from
Aug 21, 2025
+1,235 −618

Conversation

darccio
Copy link
Member

@darccio darccio commented Aug 13, 2025

What does this PR do?

Go v1.25 has been released, so it's time to bump the minimum Go version to v1.24.

It also bumps github.com/99designs/gqlgen to v0.17.72, as it was blocked by our minimum version policy.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners August 13, 2025 11:03
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 13, 2025
@datadog-official Datadog Official
Copy link

datadog-official bot commented Aug 13, 2025 •
edited by datadog-datadog-prod-us1 bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 503db7a | Docs | Was this helpful? Give us feedback!

@darccio darccio requested review from a team as code owners August 13, 2025 11:40
hannahkm
hannahkm reviewed Aug 13, 2025
View reviewed changes
@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch from 75fa3e3 to d02a9fb Compare August 13, 2025 14:41
kakkoyun
kakkoyun requested changes Aug 13, 2025
View reviewed changes
kakkoyun
kakkoyun requested changes Aug 13, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start using "oldstable" and "stable" naming.

@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch 2 times, most recently from 1fa45cd to b246fb3 Compare August 14, 2025 10:55
@darccio darccio requested a review from a team as a code owner August 14, 2025 10:55
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-08-21 09:34:39

Comparing candidate commit 503db7a in PR branch dario.castane/langplat-733/go-1.25 with baseline commit 156fe4f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

kakkoyun
kakkoyun approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch from f6da58d to cce39cd Compare August 14, 2025 15:41
@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch from 69be412 to b9e1281 Compare August 19, 2025 08:33
@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch from b9e1281 to 94be81c Compare August 21, 2025 07:47
darccio added 8 commits August 21, 2025 11:19
@darccio
feat: bump minimum Go version to 1.24
73390e6
@darccio
refactor(graph): update generated GraphQL schema and resolvers to use…
72a32e9 
… new context handling and type definitions
@darccio
fix(.gitlab): rename Go benchmark configurations to use {old,}stable …
4d79f30 
…naming
@darccio
chore(.github/workflows): update distribution versions in workflows t…
39554c3 
…o include trixie and deprecate bullseye
@darccio
chore(.gitlab): update GitLab CI configurations to clone the 'dd-trac…
2b795b5 
…e-go' branch of the benchmarking platform
@darccio
fix(internal/setup-smoke-test): replace debian12 in comment for Debia…
20e11a5 
…n 13 image build
@darccio
chore(.github/workflows): update deployment environments in smoke tes…
9804c5d 
…ts to include debian13 and remove debian11
@darccio
fix(_tools/go.mod): remove toolchain version specification
ed6decd
@darccio darccio force-pushed the dario.castane/langplat-733/go-1.25 branch from 94be81c to 503db7a Compare August 21, 2025 09:19
@darccio
Copy link
Member Author

darccio commented Aug 21, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 21, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-21 09:25:30 UTC ℹ️ Start processing command /merge

2025-08-21 09:25:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-21 09:45:15 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-21 09:56:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5fad65d into main Aug 21, 2025
253 of 255 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dario.castane/langplat-733/go-1.25 branch August 21, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahkm hannahkm hannahkm left review comments

@kakkoyun kakkoyun kakkoyun approved these changes

@genesor genesor genesor approved these changes

@rarguelloF rarguelloF rarguelloF approved these changes

@eliottness eliottness eliottness approved these changes

@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darccio @kakkoyun @genesor @rarguelloF @hannahkm @eliottness @nsrip-dd