-
Notifications
You must be signed in to change notification settings - Fork 475
internal/datastreams: add process tags to dsm payloads #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2025-06-06 15:58:32 Comparing candidate commit 03e5301 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main question about performance. Is there a way to add a RW lock on the value of process tags, and then copy on write if the value is changed?
I want to make sure the SetCheckpoint
method is not impacted performance wise.
@piochelepiotr Leaving here the benchmarks for posterity: Ran the existing benchmark on my machine:
New benchmark enabling process tags:
Tested a version of
In the end I left it the same as it is because there are no notable differences. |
Co-authored-by: Kemal Akkoyun <[email protected]>
What does this PR do?
Followup of #3566
Adds ProcessTags to DSM payloads.
(needed to update the hashing logic to include process tags as well).
Motivation
Reviewer's Checklist
golangci-lint run
locally.Unsure? Have a question? Request a review!