Skip to content

profiler: add process tags to profiling payloads #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jun 2, 2025

What does this PR do?

Followup of #3566

Adds ProcessTags to profiling payloads.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF marked this pull request as ready for review June 2, 2025 14:11
@rarguelloF rarguelloF requested review from a team as code owners June 2, 2025 14:11
@rarguelloF rarguelloF requested a review from amarziali June 2, 2025 14:11
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For posterity, this format has been discussed in the following internal docs: 1, 2.

@rarguelloF rarguelloF enabled auto-merge (squash) June 4, 2025 14:17
@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2025

Benchmarks

Benchmark execution time: 2025-06-04 14:28:26

Comparing candidate commit 2a5e619 in PR branch rarguelloF/process-tags-profiling with baseline commit b7ba964 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@rarguelloF rarguelloF merged commit f90e8ba into main Jun 4, 2025
191 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/process-tags-profiling branch June 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants