-
Notifications
You must be signed in to change notification settings - Fork 36
Propagate Step Function Trace Context through Managed Services #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanstrat
wants to merge
15
commits into
main
Choose a base branch
from
ryan.strat/sfn-managed-services
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… header and SFN context" This reverts commit a146e03.
Run code formatting
duncanista
reviewed
Jul 22, 2025
Comment on lines
+11
to
+18
if (stepFunctionContext !== undefined) { | ||
const spanContext = stepFunctionInstance.spanContext; | ||
if (spanContext !== null) { | ||
return spanContext; | ||
} | ||
} | ||
|
||
return instance.spanContext; | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like this code is exactly the same
…datadog-lambda-js into ryan.strat/sfn-managed-services
c5130af
to
a813a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for extracting step function trace context in the following cases:
Motivation
This PR adds feature parity to the JS libraries to match functionality in the python tracing library: DataDog/datadog-lambda-python#573
Testing Guidelines
I published a private layer to the ddserverless account and verified that all cases produced the intended traces. The resulting traces are below.
Additional Notes
Minor update to the publish script follows a patter from other layers to allow adding a suffix for test layer releases.
Types of Changes
Check all that apply