Skip to content

Conversation

@pgimalac
Copy link
Member

@pgimalac pgimalac commented Aug 25, 2025

What does this PR do?

Update testify to v1.11.1 https://github.com/stretchr/testify/releases/tag/v1.11.1

Motivation

Benefit from stretchr/testify#1427 (assert: check early in Eventually, EventuallyWithT, and Never).

Describe how you validated your changes

CI

Possible Drawbacks / Trade-offs

Additional Notes

The change means that some assertions now succeed earlier, which can make following assertions fail...
I had to fix various tests and increase some timeouts to avoid that.

@github-actions github-actions bot added component/system-probe team/agent-devx long review PR is complex, plan time to review it labels Aug 25, 2025
@pgimalac pgimalac added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Aug 25, 2025
@pgimalac pgimalac changed the title Update testify to v1.11.0 [ACIX-835] Update testify to v1.11.0 Aug 25, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Aug 25, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d700970f-7b12-4ea9-a5bd-1d0702e37d6f

Baseline: b5f3d90
Comparison: d5553fa
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -6.23 [-9.25, -3.21] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.86 [+0.80, +0.92] 1 Logs
otlp_ingest_metrics memory utilization +0.68 [+0.56, +0.81] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.44 [+0.24, +0.63] 1 Logs
quality_gate_idle_all_features memory utilization +0.17 [+0.13, +0.20] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.60, +0.73] 1 Logs
ddot_logs memory utilization +0.05 [+0.00, +0.10] 1 Logs
otlp_ingest_logs memory utilization +0.04 [-0.07, +0.15] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.02 [-0.11, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.25, +0.25] 1 Logs
file_tree memory utilization -0.02 [-0.06, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.61, +0.54] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.58, +0.49] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.65, +0.51] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.12 [-0.17, -0.08] 1 Logs
ddot_metrics memory utilization -0.20 [-0.37, -0.03] 1 Logs
ddot_metrics_sum_delta memory utilization -0.81 [-0.96, -0.65] 1 Logs
quality_gate_idle memory utilization -1.04 [-1.10, -0.98] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.66 [-4.42, +1.11] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.69 [-1.89, -1.48] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -4.98 [-5.14, -4.82] 1 Logs
docker_containers_cpu % cpu utilization -6.23 [-9.25, -3.21] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 25, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b5f3d90

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${697.13}$$ < $${703.13}$$ $${+0.02}$$ $${175.45}$$ < $${178.38}$$
agent_deb_amd64_fips $${0}$$ $${691.63}$$ < $${697.61}$$ $${+0.02}$$ $${174.02}$$ < $${177.15}$$
agent_heroku_amd64 $${0}$$ $${335.91}$$ < $${341.62}$$ $${-0}$$ $${88.94}$$ < $${91.52}$$
agent_msi $${0}$$ $${988.67}$$ < $${990.42}$$ $${+0.01}$$ $${150.88}$$ < $${152.42}$$
agent_rpm_amd64 $${0}$$ $${697.12}$$ < $${703.12}$$ $${+0.01}$$ $${177.79}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${691.62}$$ < $${697.6}$$ $${+0.01}$$ $${176.19}$$ < $${178.87}$$
agent_rpm_arm64 $${0}$$ $${683.25}$$ < $${689.82}$$ $${+0.01}$$ $${159.07}$$ < $${162.16}$$
agent_rpm_arm64_fips $${0}$$ $${678.76}$$ < $${685.08}$$ $${+0.02}$$ $${157.95}$$ < $${161.11}$$
agent_suse_amd64 $${0}$$ $${697.12}$$ < $${703.12}$$ $${+0.01}$$ $${177.79}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${691.62}$$ < $${697.6}$$ $${+0.01}$$ $${176.19}$$ < $${178.87}$$
agent_suse_arm64 $${0}$$ $${683.25}$$ < $${689.82}$$ $${+0.01}$$ $${159.07}$$ < $${162.16}$$
agent_suse_arm64_fips $${0}$$ $${678.76}$$ < $${685.08}$$ $${+0.02}$$ $${157.95}$$ < $${161.11}$$
docker_agent_amd64 $${0}$$ $${768.51}$$ < $${774.54}$$ $${+0}$$ $${263.2}$$ < $${266.46}$$
docker_agent_arm64 $${+0}$$ $${778.58}$$ < $${785.2}$$ $${-0}$$ $${249.27}$$ < $${252.92}$$
docker_agent_jmx_amd64 $${+0}$$ $${959.37}$$ < $${965.41}$$ $${+0}$$ $${331.82}$$ < $${335.08}$$
docker_agent_jmx_arm64 $${-0}$$ $${958.04}$$ < $${964.66}$$ $${-0}$$ $${313.88}$$ < $${317.54}$$
docker_cluster_agent_amd64 $${0}$$ $${212.85}$$ < $${213.74}$$ $${-0}$$ $${72.2}$$ < $${73.2}$$
docker_cluster_agent_arm64 $${+0}$$ $${228.8}$$ < $${229.68}$$ $${+0}$$ $${68.49}$$ < $${69.48}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.06}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.39}$$ < $${39.3}$$ $${0}$$ $${14.83}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.05}$$ < $${37.94}$$ $${-0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.62}$$ < $${30.53}$$ $${-0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.21}$$ < $${29.12}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.62}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.77}$$
dogstatsd_suse_amd64 $${0}$$ $${29.62}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.77}$$
iot_agent_deb_amd64 $${0}$$ $${54.57}$$ < $${54.97}$$ $${-0}$$ $${13.64}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.85}$$ < $${51.9}$$ $${+0}$$ $${11.76}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.38}$$ < $${51.84}$$ $${-0}$$ $${11.84}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.57}$$ < $${54.97}$$ $${-0}$$ $${13.66}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${54.57}$$ < $${54.97}$$ $${-0}$$ $${13.66}$$ < $${14.47}$$

@pgimalac pgimalac force-pushed the pgimalac/bump-testify branch from 41aa326 to 46ddae6 Compare August 25, 2025 17:21
@pgimalac pgimalac changed the title [ACIX-835] Update testify to v1.11.0 [ACIX-835] Update testify to v1.11.1 Aug 28, 2025
@pgimalac pgimalac requested review from a team as code owners September 23, 2025 12:58
@pgimalac pgimalac requested review from AyyLam and fabbing September 23, 2025 12:58
@pgimalac pgimalac added the ask-review Ask required teams to review this PR label Sep 23, 2025
Copy link
Contributor

@louis-cqrl louis-cqrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for arun files

@pducolin
Copy link
Collaborator

Omg they finally merged this fix!

Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for fleet

require.Equal(t, value, actualEvents[evName], "event %s count mismatch", evName)
delete(actualEvents, evName)
}
require.EventuallyWithT(t, func(c *assert.CollectT) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question
Do we need these changes on .go files? They make the PR blurrier, are they a consequence of the bump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a consequence
Basically the timing change in Eventually[WithT] made various tests flaky, I fixed most of them in a separate PR, but KMT tests were particularly tricky and had to be fixed by owning teams (who pushed to this PR)
I could technically split those commits in separate PRs too, but it seemed simpler to just keep the current state

@pgimalac
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 29, 2025

View all feedbacks in Devflow UI.

2025-09-29 14:04:25 UTC ℹ️ Start processing command /merge


2025-09-29 14:04:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-29 18:05:03 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@pgimalac
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 30, 2025

View all feedbacks in Devflow UI.

2025-09-30 10:53:26 UTC ℹ️ Start processing command /merge


2025-09-30 10:53:38 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-30 11:09:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 37m (p90).


2025-09-30 11:11:40 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

Error: gitlab pipeline not started

@pgimalac
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 30, 2025

View all feedbacks in Devflow UI.

2025-09-30 11:14:40 UTC ℹ️ Start processing command /merge


2025-09-30 11:14:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 37m (p90).


2025-09-30 12:01:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9e9fd8d into main Sep 30, 2025
570 of 574 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/bump-testify branch September 30, 2025 12:01
@github-actions github-actions bot added this to the 7.72.0 milestone Sep 30, 2025
dd-mergequeue bot pushed a commit that referenced this pull request Oct 15, 2025
### What does this PR do?

Ensure that e2e tests are using testify v1.11.1 to benefit from stretchr/testify#1427.

### Motivation

With the merge of #40182, I expected the elapsed time of containers e2e tests to be significantly reduced.
Indeed, most of the tests are just waiting with an `EventuallyWithT` for an assertion against fake intake data to become true.
And, most of the time, the assertion should be true at the first try. So, the 10+s of elapsed for the tests was coming from the `EventuallyWithT` initial try.

And, according to [this CI page](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40test.service%3Adatadog-agent%20%40git.branch%3Amain%20%40test.suite%3A%22github.com%2FDataDog%2Fdatadog-agent%2Ftest%2Fnew-e2e%2Ftests%2Fcontainers%22%20%40test.name%3A%22TestEKSSuite%2FTestNginx%2Fmetric___network.http.response_time%7B%5Ekube_namespace%3Aworkload-nginx%24%7D%22&citest_explorer_sort=time%2Cdesc&currentTab=overview&eventStack=&fromUser=false&index=citest&mode=sliding&saved-view-id=2236559&start=1759918899379&end=1760523699379&paused=false), containers e2e tests  are still lasting more than 10s despite the merge of #40182.

### Describe how you validated your changes

I checked the *real* version of testify used by the e2e tests by:
* starting them with: `dda inv -- -e new-e2e-tests.run --targets ./tests/containers --run TestEKSSuite`
* looking for the test binary with: `pstree -p $(pgrep konsole)`
* and finally checking the testify version with: `strings /proc/80184/exe | grep testify | grep v1.1`

Before this PR, I had:
```
lenaic@lenaic-Precision-5570:~$ strings /proc/80184/exe | grep testify | grep v1.1
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_compare.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_format.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_order.go
[…]
```

With this PR, I now have:
```
lenaic@lenaic-Precision-5570:~$ strings /proc/90732/exe | grep testify | grep v1.1
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_compare.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_format.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_order.go
[…]
```

### Additional Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants