Skip to content

Fix/split listener #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 8, 2023
Merged

Fix/split listener #228

merged 9 commits into from
Dec 8, 2023

Conversation

HaydenOrz
Copy link
Collaborator

主要变更

  1. 优化所有 sql 的 splitListenr，优化后，所有的 splitListenr 切割出的sql语句包含语句结尾的分号，如果该sql 支持空语句，那么切割结果中也包含空语句
  2. 为所有 sql 类型的 splitListenr 添加单元测试

遗留问题

修改 splitListenr 后，部分parser 的自动补全功能出现了bug，这个bug是本来就存在的。后续用单独 PR 修复此问题

@HaydenOrz HaydenOrz added bug Something isn't working improvement Improve existing feature labels Dec 7, 2023
@liuxy0551
Copy link
Collaborator

pg 的单测有点问题

@HaydenOrz HaydenOrz merged commit 23f5aac into DTStack:main Dec 8, 2023
@HaydenOrz HaydenOrz mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckyFBB LuckyFBB LuckyFBB approved these changes

@Cythia828 Cythia828 Awaiting requested review from Cythia828

@liuxy0551 liuxy0551 Awaiting requested review from liuxy0551

Assignees
No one assigned
Labels
bug Something isn't working improvement Improve existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaydenOrz @liuxy0551 @LuckyFBB