Skip to content

Update workflows for dev and test to include Cypress tests#240

Merged
DrizzlyOwl merged 5 commits intomainfrom
add-cypress-actions
Apr 19, 2023
Merged

Update workflows for dev and test to include Cypress tests#240
DrizzlyOwl merged 5 commits intomainfrom
add-cypress-actions

Conversation

@cshnimble
Copy link
Copy Markdown
Contributor

@cshnimble cshnimble commented Apr 13, 2023

Introduces Cypress tests to the GitHub actions for deployments to development and test environments.

Will require (if they don't already exist) some secrets adding to GitHub. Alternatively, if they already exist and the command needs updating:

  • URL: The url of the academisation api in dev and test
  • API_KEY: The api key for the academisation api in dev and test

@cshnimble cshnimble marked this pull request as ready for review April 14, 2023 13:18
@DrizzlyOwl
Copy link
Copy Markdown
Collaborator

Hi @cshnimble great work here. This repo is using an older deployment workflow so I would like to propose we update it to a more up-to-date version which combines the individual YML files into 1 single workflow. You can see how we have incorporated the Cypress tests in other repos here so I would prefer to update the whole workflow and bundle your Cypress test into that change.

What do you think?

@cshnimble
Copy link
Copy Markdown
Contributor Author

Hi @DrizzlyOwl I'm totally on board with that, can either do it as part of this PR or as a separate one and close this if you prefer?

@DrizzlyOwl
Copy link
Copy Markdown
Collaborator

@cshnimble I think it could be merged into this PR if you're happy to rebase your changes over the top of the GitHub workflow for the Academies API?

@cshnimble cshnimble marked this pull request as draft April 17, 2023 11:26
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DrizzlyOwl DrizzlyOwl marked this pull request as ready for review April 19, 2023 09:31
Copy link
Copy Markdown
Collaborator

@DrizzlyOwl DrizzlyOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets have been updated to include the ones referenced in the PR

@DrizzlyOwl DrizzlyOwl merged commit 270abc2 into main Apr 19, 2023
@DrizzlyOwl DrizzlyOwl deleted the add-cypress-actions branch April 19, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants