Typed rows via manual assembly#2
Merged
l3pp4rd merged 2 commits intoDATA-DOG:masterfrom Feb 13, 2014
Merged
Conversation
Member
|
looks really good, nice contribution to the API, thanks ;) will update few things and merge it |
l3pp4rd
pushed a commit
that referenced
this pull request
May 31, 2017
* Update sqlmock.go Permit prepares to obey MatchExpectationsInOrder flag, allowing prepared statements to be prepared in a different order than they were added to the expectations. * Update sqlmock_test.go Add test case for unordered prepared statements.
|
Can you guys make sure you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
closes #1
I think this is a decent implementation as it allows for multiple rows to be added as a result with a fairly simple API.
Here's how it looks:
Allowing rows to be generated by function calls could make a good future improvement, but I only need a single row for all my current tests and this works nicely.