Enable ibcv3 feature for cw-proposal-single contract#318
Merged
0xekez merged 9 commits intoDA0-DA0:mainfrom Jun 7, 2022
Merged
Conversation
de-husk
changed the title
JakeHartnell
requested review from
0xekez,
Callum-A,
ethanfrey,
maurolacy and
orkunkl
Callum-A
approved these changes
Jun 4, 2022
0xekez
suggested changes
Jun 6, 2022
Contributor
0xekez
left a comment
0xekez
left a comment
There was a problem hiding this comment.
This is really nice. Thanks!
Would be nice to test that these new message types can be executed by the core module before we merge this. I have a suspicion that without the dependency there it isn't going to know how to parse these in ExecuteProposalHook.
0xekez
approved these changes
Jun 7, 2022
Contributor
0xekez
left a comment
0xekez
left a comment
There was a problem hiding this comment.
Amazing! Thanks for putting this together. Super important for supporting IBC stuff. Glad you caught this before we deployed.
de-husk
force-pushed
the
samangan/enable-stargate-feature-for-cosmwasm-std
branch
from
f997552 to
bbb965a
Compare
JakeHartnell
pushed a commit
that referenced
this pull request
Dec 13, 2023
Migrate contracts to 0.15.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we were trying to create a proposal with a create validator transaction, we found out that we dont currently support the
stargatefield in a CosmosMsg.I decided to enable the ibc3 feature, which includes the
stargatefeatures and the new ibcv3 interchain account stuff.