docs: clarify stealth init script visibility#353
Open
mturac wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for this. I think this is patchright working as intended rather than a bug, since the init script does run, it just sits in the isolated world so your evaluate calls can't see it. Anyone who needs it in the main world can already pass isolated_context=False. My honest take is this doesn't really need a code change and a short docs note would cover it, but happy to be wrong. |
Author
|
Good point, thanks for the context. I replaced the runtime change with a docs-only note that keeps the existing behavior intact and points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init_scriptinteracts with Patchright's isolated execution context in Stealthy modepage_actionusers topage.evaluate(..., isolated_context=False)when they need to read globals placed onwindowRefs #350
Tests
git diff --check origin/main...HEAD