Re-added php and ruby to the binary SBOMs #2277
Conversation
malice00
added
bug
| apt install -y curl | ||
| - libc: musl | ||
| image: alpine:3.16 | ||
| image: php:8.4-alpine3.21 |
There was a problem hiding this comment.
Will this make our musl builds >= 3.21?
There was a problem hiding this comment.
It should not, but will check when I download a binary
There was a problem hiding this comment.
Runs just fine on 3.16. I believe it's the node binary that counts, which is still produced on an older images. I don't think the choice of image really influences the binary that is getting created, tbh.
There was a problem hiding this comment.
What about debian 12? I am surprised it will run on debian 11 since node-sqlite3 would be built against the latest glibc?
There was a problem hiding this comment.
I changed back to debian 11 in the latest commit. Not sure what you mean though, we've been using that for quite some time?
There was a problem hiding this comment.
my bad. didn't see the change.
Signed-off-by: Roland Asmann <[email protected]>
malice00
force-pushed
the
binary_builds/types
branch
from
26fd0d8 to
faee040
Compare
PHP and ruby were not in the SBOM, because they were not working in the workflows. I made some changes and added them back now: