JS-implementation of getting runtime + version #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhu
reviewed
Jul 21, 2025
bin/cdxgen.js
Outdated
| ? "(security doesn't allow retrieval')" | ||
| : result.stdout.trim(); | ||
| version = `${version}\nNode: ${process.execPath}, version: ${nodeVersion}`; | ||
| if (typeof globalThis.Deno !== "undefined" && globalThis.Deno.version?.deno) { |
There was a problem hiding this comment.
Can we move this to envcontext.collectNodeInfo and convert the returned object to a string? This way the correct information will be captured even for --include-formulation invocations.
There was a problem hiding this comment.
Looking at envcontext.collectNodeInfo -- not sure if that is the best place to put this. We're also getting information about npm there, which might not necessarily be available...
Signed-off-by: Roland Asmann <[email protected]>
Signed-off-by: Roland Asmann <[email protected]>
malice00
force-pushed
the
version
branch
2 times, most recently
from
78e6dd1 to
9cc208c
Compare
…ontext as well Signed-off-by: Roland Asmann <[email protected]>
|
@prabhu What do you think of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation just added only supported NodeJS and was calling the binary to check. This version is fully implemented in JavaScript and can handle Deno and Bun as well.