feat: add brute force protection for SMS verification codes #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousLearner
force-pushed
the
pr-117
branch
5 times, most recently
from
6e3e7b0 to
9efb7fd
Compare
Add comprehensive brute force protection to prevent automated attacks on SMS verification codes: - Add failed_attempts field to SMSVerification model with database migration - Implement MAX_FAILED_ATTEMPTS setting (default: 5) for session lockout - Implement MIN_TOKEN_LENGTH setting (default: 6) to enforce minimum security code length - Track failed attempts for invalid, expired, and already-verified codes - Reset failed_attempts to 0 on successful verification - Update validation logic to check brute force limit before other validations - Add SECURITY_CODE_TOO_MANY_ATTEMPTS status code and error handling - Update sandbox backends to support brute force protection while maintaining test-friendly behavior - Add comprehensive test coverage for brute force protection scenarios - Update documentation with new security settings Closes #100 Co-authored-by: Harsh <[email protected]>
CuriousLearner
force-pushed
the
pr-117
branch
from
9efb7fd to
afc0315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement comprehensive brute force protection with the following changes:
Closes #100 Superseeds #117