Skip to content

Conversation

capuanob
Copy link
Contributor

@capuanob capuanob commented Jun 10, 2024

Hello! Apologies for the long delay in getting this implemented, as discussed in Issue 744 with @gittiver.

I would greatly appreciate your review and integration of this PR.

As an overview of what next steps are for me to integrate this project fully into OSSFuzz:

  1. Once this is merged, I will submit a Dockerfile to google/oss-fuzz for continuous fuzz-testing of the defined harnesses
  2. Once Google merges in the Dockerfile, the project is ready to fuzz!

Please let me know if there are any questions or concerns!

Changed titlecase to lowercase for project name in build.sh

Don't build examples or test for Crow fuzzing

Signficiantly simplified corpus

Added cifuzz.yml

Clean up

More fixes
@gittiver
Copy link
Member

Building the fuzzers on GitHub has a problem, do you have an idea what is going wrong?

@capuanob
Copy link
Contributor Author

Building the fuzzers on GitHub has a problem, do you have an idea what is going wrong?

@gittiver The OSSFuzz CI build will fail until this PR is merged and until I get approval for a subsequent, dependent PR to google/oss-fuzz. It is currently trying to retrieve these fuzz files from the default branch of the repository, but it is not yet there (bit of a chicken and the egg problem).

@gittiver
Copy link
Member

so we have to wait for the other approval?

@capuanob
Copy link
Contributor Author

capuanob commented Jun 20, 2024 via email

@gittiver
Copy link
Member

This PR needs to be merged first. Once you merge it, I will work with OSS-Fuzz to begin fuzzing!
So it will not break the build on main branch on merge? It's hard to check if it will work before merging int.

@capuanob
Copy link
Contributor Author

capuanob commented Jun 20, 2024 via email

@gittiver gittiver merged commit ea63a47 into CrowCpp:master Jun 21, 2024
jonathanmetzman pushed a commit to google/oss-fuzz that referenced this pull request Jul 1, 2024
The harnesses and build.sh have already been integrated into master, as
seen in this this [PR](CrowCpp/Crow#830)

This pull request solely adds the necessary Dockerfile
andrew-guz pushed a commit to bgs99/Crow that referenced this pull request Sep 13, 2024
Added cifuzz.yml
Don't build examples or test for Crow fuzzing
Changed titlecase to lowercase for project name in build.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants