Fix failing unittests in master and 1.0 #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing when built using my mingw64-11.2.0 toolset on the Windows platform, on the 1.0+3 release.
…ary strings std::strings with binary data should always be created with the constructor taking a char pointer and the length of the character data.
…d wait_for_server_start() could lead to deadlock This is the case in some short, simple unit tests, such as "get_port".
The-EDev
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created pull request on master instead of the 1.0-branch, as requested (ref. pull request #460).
Running the unit tests on the master branch uncovered a race condition in a short test, where the server is started, waited for and then almost immediately stopped again. The race condition resulted in a deadlock. A proposed fix for this issue is in commit 3782044.