Skip to content

erase websocket::connection from vector in App::remove_websocket() #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

erase websocket::connection from vector in App::remove_websocket() #450

merged 1 commit into from
Jun 3, 2022

Conversation

MichaelSB
Copy link
Contributor

As requested, this is the fix for #449

@The-EDev The-EDev linked an issue Jun 3, 2022 that may be closed by this pull request
Crow::remove_websocket: does not erase connection from vector #449
Closed
The-EDev
The-EDev approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thank you for your help

@The-EDev The-EDev merged commit 017c6e3 into CrowCpp:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crow::remove_websocket: does not erase connection from vector
2 participants
@MichaelSB @The-EDev