Support for CROW_USE_LOCALTIMEZONE for using localtime in logs

[kingster]

Hi @The-EDev

This changes gmtime_* to localtime_* to use local dates in the logs. Most other HTTP servers usually use local date time by default, hence changing this.

Also wanted your views if this should be configurable or not using a #ifdef? What do you think?

[The-EDev]

As mentioned here, I think it's best if GMT is default and there's a macro to change it to local time. I just don't know what happened to the work I was supposed to do..

[kingster]

Updated the PR with CROW_USE_LOCALTIMEZONE. This will now require an explicit option using #define CROW_USE_LOCALTIMEZONE 1 before including the crow headers

[The-EDev]

The time in http_server.h must be GMT and not local to the server as per HTTP, please revert the last commit.

[kingster]

The time in http_server.h must be GMT and not local to the server as per HTTP, please revert the last commit.

Done. Sorry, wasn't aware of this.

[The-EDev]

No worries, and thanks a lot for taking the time to work on improving Crow!

[crow-clang-format]

--- include/crow/logging.h	(before formatting)
+++ include/crow/logging.h	(after formatting)
@@ -72,17 +72,17 @@
             tm my_tm;
 
 #if defined(_MSC_VER) || defined(__MINGW32__)
-    #ifdef CROW_USE_LOCALTIMEZONE
+#ifdef CROW_USE_LOCALTIMEZONE
             localtime_s(&my_tm, &t);
-    #else
+#else
             gmtime_s(&my_tm, &t);
-    #endif
+#endif
 #else
-    #ifdef CROW_USE_LOCALTIMEZONE
+#ifdef CROW_USE_LOCALTIMEZONE
             localtime_r(&t, &my_tm);
-    #else
+#else
             gmtime_r(&t, &my_tm);
-    #endif
+#endif
 #endif
 
             size_t sz = strftime(date, sizeof(date), "%Y-%m-%d %H:%M:%S", &my_tm);

[The-EDev]

Seems like the only thing left is formatting.

[kingster]

Had already fixed the formatting error reported by crow-clang-format. Hoping this time it will pass all the checks.

[kingster]

@The-EDev Please check. Github CI reports that all check have passed