Fix inconsistencies in concurrency
#307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrozigor
reviewed
Dec 20, 2021
mrozigor
previously approved these changes
Dec 22, 2021
(it actually reflects the thread count properly)
mrozigor
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concurrency(whether the variable or function) used to represent the number of worker threads to be used.This PR changes that to include the primary thread (acceptor thread) as well as all the worker threads.
This does have the effect of making Crow report a minimum of 2 threads (which is the actual minimum thread count).
I also removed the redundant check for the value being
0inhttp_server.hsince that's already being done inapp.h.