Extract SyncResolverApi interface and SyncDeviceManager class#3943
Merged
guiyanakuang merged 2 commits intomainfrom Feb 24, 2026
Merged
Extract SyncResolverApi interface and SyncDeviceManager class#3943guiyanakuang merged 2 commits intomainfrom
guiyanakuang merged 2 commits intomainfrom
Conversation
guiyanakuang
deleted the
refactor/issue-3942-extract-sync-resolver-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3942
Summary
SyncResolverApiinterface —SyncResolvernow implements this interface;GeneralSyncManagerand Koin bindings depend on the abstraction instead of the concrete classSyncDeviceManagerclass — 7 device management methods moved fromSyncResolverinto a focused class with only 3 dependencies (SecureStore,SyncClientApi,SyncRuntimeInfoDao)SyncResolverTestto dedicatedSyncDeviceManagerTest, each mocking only 3 deps instead of 10+Test plan
./gradlew app:desktopTest --tests "com.crosspaste.sync.*"— all sync tests pass./gradlew ktlintFormat— passes