Add 111 unit tests for sync layer and fix HostInfoFilter DNS resolution#3816
Merged
guiyanakuang merged 1 commit intomainfrom Feb 9, 2026
Merged
Add 111 unit tests for sync layer and fix HostInfoFilter DNS resolution#3816guiyanakuang merged 1 commit intomainfrom
guiyanakuang merged 1 commit intomainfrom
Conversation
…tion Add comprehensive test coverage for the core sync/discovery/connection subsystem, and fix HostInfoFilter to reject non-IP strings that could trigger unintended DNS resolution. Test classes: - SyncResolverTest (50): event dispatch, state transitions, heartbeat - GeneralSyncHandlerTest (20): state machine, API delegation - SyncPasteTaskExecutorTest (13): eligibility, sync execution, retry - TelnetHelperTest (11): single host telnet, parallel switchHost - GeneralNearbyDeviceManagerTest (10): device add/remove, blacklist - SyncPollingManagerTest (7): backoff, reset, cancellation - SyncTestFixtures: shared factory methods Production changes: - Extract TokenCacheApi interface for testable dependency injection - Add looksLikeIpLiteral() guard in HostInfoFilter.resolveIpBytes() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3815
Summary
TokenCacheApiinterface fromTokenCacheobject for clean dependency injection in testsHostInfoFilter.resolveIpBytes()to reject non-IP strings that trigger unintended DNS resolutionTest classes
Production changes
TokenCacheApiinterface;TokenCacheobject implements itTokenCacheApiinstead ofTokenCacheconcrete typeTokenCacheApiin KoinlooksLikeIpLiteral()guard to prevent DNS resolution of non-IP stringsTest plan
🤖 Generated with Claude Code