Fix runBlocking UI freeze and redundant koinInject in device sync UI#3804
Merged
guiyanakuang merged 1 commit intomainfrom Feb 9, 2026
Merged
Fix runBlocking UI freeze and redundant koinInject in device sync UI#3804guiyanakuang merged 1 commit intomainfrom
guiyanakuang merged 1 commit intomainfrom
Conversation
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3803
Changes
1. Fix
runBlockingUI freeze in AddDeviceDialog (HIGH)runBlockingwithrememberCoroutineScope().launchso the network call (syncClientApi.syncInfo) no longer blocks the UI threadisLoadingstate to disable the confirm button during the async request, preventing double-clicks2. Remove redundant
koinInjectin DevicesContentView (LOW)koinInject<DeviceScopeFactory>()inside LazyColumnitemslambda — the factory was already injected in the outer composable scopeVerification
./gradlew ktlintFormat— clean./gradlew compileKotlinDesktop— passes./gradlew app:desktopTest— 154/155 pass (1 pre-existing env-dependent failure)