Fix resource leaks and bitmap copy bug in image processing#3774
Merged
guiyanakuang merged 2 commits intomainfrom Feb 8, 2026
Merged
Fix resource leaks and bitmap copy bug in image processing#3774guiyanakuang merged 2 commits intomainfrom
guiyanakuang merged 2 commits intomainfrom
Conversation
guiyanakuang
force-pushed
the
fix/image-media-resource-leaks
branch
from
3c8acda to
e9e9ca4
Compare
- WebpImageWriter: close FileImageOutputStream and dispose ImageWriter
after writing to prevent file handle leaks
- DesktopThumbnailLoader: wrap InputStream and OutputStream in .use {}
for readOriginMeta and defaultSave to ensure proper cleanup
- MacCropTransformation: fix fallback pixel copy to use readPixels +
installPixels instead of discarding the read result
- DesktopIconColorExtractor: replace plain MutableMap with
ConcurrentHashMap for thread-safe access under StripedMutex
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
guiyanakuang
force-pushed
the
fix/image-media-resource-leaks
branch
from
e9e9ca4 to
200c4b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileImageOutputStreamand disposeImageWriterviatry/finallyto prevent file handle leaksInputStreamandOutputStreamin.use {}forreadOriginMetaanddefaultSavereadPixels+installPixelsinstead of discarding the read resultMutableMapwith KtorConcurrentMap+Optional<Color>for thread-safe access underStripedMutexFixes #3773
Test plan
extractSubset)ConcurrentModificationException🤖 Generated with Claude Code