🐛 Fix duplicate retry condition and check() crash in sync task executors#3766
Merged
guiyanakuang merged 1 commit intomainfrom Feb 8, 2026
Merged
🐛 Fix duplicate retry condition and check() crash in sync task executors#3766guiyanakuang merged 1 commit intomainfrom
guiyanakuang merged 1 commit intomainfrom
Conversation
- Fix duplicate SYNC_NOT_ALLOW_RECEIVE_BY_APP in noNeedRetry check, replace with SYNC_NOT_ALLOW_SEND_BY_APP so send-permission failures are correctly treated as non-retryable - Replace check() assertion in PullFileTaskExecutor with proper failure result to avoid opaque IllegalStateException on unexpected PasteFiles count Closes #3765 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3765
Summary
Code review Session 13 fixes for sync task executors:
SYNC_NOT_ALLOW_RECEIVE_BY_APPinnoNeedRetrycheck — the second condition was a copy-paste bug and should beSYNC_NOT_ALLOW_SEND_BY_APP. Previously, sync tasks that failed due to send-permission errors would be incorrectly retried up to 3 times.check(fileItems.isNotEmpty() && fileItems.size == 1)inPullFileTaskExecutorwith a properdoFailure()result. Thecheck()threw an opaqueIllegalStateException("Check failed") that was caught byTaskExecutoras a non-retryable failure with no useful error message.Test plan
HostInfoFilterTest.testInvalidSelfIPAddress) is unrelated🤖 Generated with Claude Code