Fix image resource leak, redundant hash computation, and silent plugin failures#3748
Merged
guiyanakuang merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
…gin failures
- Add clear() override to ImagesPasteItem to clean up stored images on deletion
- Avoid redundant hash/count/size recalculation in ImagesPasteItem.bind()
- Close InputStream with .use {} in DesktopRtfTypePlugin
- Add logger.warn for RTF conversion and image write failures
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3747
Changes
clear()override — MirrorsFilesPasteItem.clear()logic to delete stored image files when paste data is removed, fixing a disk space leakbind()— Use direct constructor instead ofcreateImagesPasteItem()to avoid redundant hash/count/size recalculation (hash computation can be expensive).use { it.readBytes() }to ensure the stream from Java AWT Transferable is properly closedlogger.warnwhenrtfToHtml()returns nulllogger.warnwhenwriteImage()returns false