🐛 Correct background and icon color contrast issues#2742
Merged
guiyanakuang merged 1 commit intomainfrom May 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses background and icon color contrast issues (#2741) by refactoring the theme color selection logic in the ContrastColor function. Key changes include defining dedicated container and tint color variables for Standard, Medium, and High contrast modes and updating button configurations accordingly.
app/src/commonMain/kotlin/com/crosspaste/ui/settings/ThemeSegmentedControl.kt
Show resolved
Hide resolved
guiyanakuang
force-pushed
the
2741-correct-background-and-icon-color-contrast-issues
branch
from
d7f40e5 to
eaca74e
Compare
guiyanakuang
deleted the
2741-correct-background-and-icon-color-contrast-issues
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2741