Skip to content

🐛 Fix ExpandView java.lang.AbstractMethodError#2727

Merged
guiyanakuang merged 1 commit intomainfrom
2726-fix-expandview-javalangabstractmethoderror
May 14, 2025
Merged

🐛 Fix ExpandView java.lang.AbstractMethodError#2727
guiyanakuang merged 1 commit intomainfrom
2726-fix-expandview-javalangabstractmethoderror

Conversation

@guiyanakuang
Copy link
Copy Markdown
Member

close #2726

@guiyanakuang guiyanakuang added this to the CrossPaste 1.2.0 milestone May 14, 2025
@guiyanakuang guiyanakuang self-assigned this May 14, 2025
@guiyanakuang guiyanakuang requested a review from Copilot May 14, 2025 08:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a bug causing a java.lang.AbstractMethodError by aligning the composable function parameter signatures between the desktop and common implementations of the ExpandViewProvider.

  • Removed scope receiver modifiers from the barContent and content parameters.
  • Updated import statements to remove unused scope types.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/src/desktopMain/kotlin/com/crosspaste/ui/base/DesktopExpandViewProvider.kt Changed composable parameter signatures and removed unused layout scope imports.
app/src/commonMain/kotlin/com/crosspaste/ui/base/ExpandViewProvider.kt Modified composable parameter types to match the desktop provider.
Comments suppressed due to low confidence (2)

app/src/desktopMain/kotlin/com/crosspaste/ui/base/DesktopExpandViewProvider.kt:62

  • The removal of RowScope and ColumnScope from the composable parameters changes the API contract. Please verify that downstream composable implementations are updated accordingly to prevent future issues.
barContent: @Composable (Float) -> Unit,

app/src/commonMain/kotlin/com/crosspaste/ui/base/ExpandViewProvider.kt:22

  • Changing the composable parameter types to remove scope receivers ensures consistency with the desktop provider but requires confirming that all implementations are compatible with the updated signatures.
barContent: @Composable (Float) -> Unit,

@guiyanakuang guiyanakuang merged commit f35f316 into main May 14, 2025
2 checks passed
@guiyanakuang guiyanakuang deleted the 2726-fix-expandview-javalangabstractmethoderror branch July 12, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ExpandView java.lang.AbstractMethodError

2 participants