🐛 Fix ExpandView java.lang.AbstractMethodError#2727
Merged
guiyanakuang merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug causing a java.lang.AbstractMethodError by aligning the composable function parameter signatures between the desktop and common implementations of the ExpandViewProvider.
- Removed scope receiver modifiers from the barContent and content parameters.
- Updated import statements to remove unused scope types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/desktopMain/kotlin/com/crosspaste/ui/base/DesktopExpandViewProvider.kt | Changed composable parameter signatures and removed unused layout scope imports. |
| app/src/commonMain/kotlin/com/crosspaste/ui/base/ExpandViewProvider.kt | Modified composable parameter types to match the desktop provider. |
Comments suppressed due to low confidence (2)
app/src/desktopMain/kotlin/com/crosspaste/ui/base/DesktopExpandViewProvider.kt:62
- The removal of RowScope and ColumnScope from the composable parameters changes the API contract. Please verify that downstream composable implementations are updated accordingly to prevent future issues.
barContent: @Composable (Float) -> Unit,
app/src/commonMain/kotlin/com/crosspaste/ui/base/ExpandViewProvider.kt:22
- Changing the composable parameter types to remove scope receivers ensures consistency with the desktop provider but requires confirming that all implementations are compatible with the updated signatures.
barContent: @Composable (Float) -> Unit,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2726