🐛 Fixed an issue where after a device applies for a new IP address, it is not synchronized to other devices

[guiyanakuang]

close #2714

[Copilot]

Pull Request Overview

This PR fixes a synchronization bug where a device’s newly applied IP address wasn't properly propagated to other devices. Key changes include updating API calls from update to updateSyncRuntimeInfo, converting several methods to suspend functions, and modifying the refresh behavior in the GeneralNearbyDeviceManager.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

File	Description
DesktopCrossPasteModule.kt	Updated instantiation of GeneralNearbyDeviceManager to remove an extraneous dependency
DeviceDetailContentView.kt	Revised calls to use updateSyncRuntimeInfo instead of update
SyncHandler.kt & MarketingSyncHandler.kt	Renamed update methods to updateSyncRuntimeInfo for consistency
MarketingNearbyDeviceManager.kt & GeneralNearbyDeviceManager.kt	Changed device management methods (add, remove, refresh) to suspend functions and adjusted refresh logic

Comments suppressed due to low confidence (3)

app/src/commonMain/kotlin/com/crosspaste/sync/GeneralSyncHandler.kt:204

• [nitpick] The private 'update' function called here shares a similar name to the public 'updateSyncRuntimeInfo' and might be confusing. Consider renaming the private helper (e.g., to 'performUpdate') to better differentiate its purpose.

return mutex.withLock { update { doUpdate(it) } }

app/src/commonMain/kotlin/com/crosspaste/sync/GeneralNearbyDeviceManager.kt:64

• [nitpick] The revised refresh logic iterates over syncRuntimeInfos and calls updateSyncRuntimeInfo individually; consider whether a batched update might reduce overhead when processing many devices.

for (syncRuntimeInfo in existSyncRuntimeInfos) { ... }

app/src/desktopMain/kotlin/com/crosspaste/DesktopCrossPasteModule.kt:303

• Ensure that the removal of the extra dependency is intentional and that the new constructor signature of GeneralNearbyDeviceManager fully supports all required functionality.

GeneralNearbyDeviceManager(get(), get(), get(), get())