💄 Create the display effect for HighlightedCard prompt UI#2703
Merged
guiyanakuang merged 1 commit intomainfrom May 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
The PR introduces a new UI display effect by replacing the manual usage of clip and background modifiers with a reusable HighlightedCard composable component to standardize the appearance of settings and preview views.
- Replaces Columns with explicit clip/background modifiers with HighlightedCard in multiple UI views.
- Adds the new HighlightedCard component to encapsulate elevation, border, and shape properties for a consistent card appearance.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/desktopMain/kotlin/com/crosspaste/ui/settings/SetStoragePathView.kt | Removed clip modifier; consider adopting the HighlightedCard component for a consistent UI display. |
| app/src/desktopMain/kotlin/com/crosspaste/ui/settings/MainSettingsContentView.kt | Replaced manual styling in a Column with HighlightedCard to leverage centralized styling. |
| app/src/desktopMain/kotlin/com/crosspaste/ui/base/ExpandView.desktop.kt | Updated container from Column to HighlightedCard, ensuring appropriate modifiers are applied. |
| app/src/desktopMain/kotlin/com/crosspaste/ui/TabsView.kt | Converted a Column container to HighlightedCard for a more consistent card look in TabsView. |
| app/src/commonMain/kotlin/com/crosspaste/ui/settings/StoreSettingsContentView.kt | Removed redundant clip modifiers in favor of a unified card presentation. |
| app/src/commonMain/kotlin/com/crosspaste/ui/settings/PasteboardSettingsContentView.kt | Simplified view styling by removing clip modifiers; background remains consistent. |
| app/src/commonMain/kotlin/com/crosspaste/ui/settings/NetSettingsContentView.kt | Standardized container styling by removing clip modifiers across multiple Column usages. |
| app/src/commonMain/kotlin/com/crosspaste/ui/paste/preview/PastePreviewItemView.kt | Replaced the Row container with HighlightedCard for a unified preview appearance. |
| app/src/commonMain/kotlin/com/crosspaste/ui/base/MobileExpandView.kt | Switched from Column to HighlightedCard to improve consistency in mobile expand view styling. |
| app/src/commonMain/kotlin/com/crosspaste/ui/base/HighlightedCard.kt | Introduced the new HighlightedCard composable to centralize card styling logic. |
Comments suppressed due to low confidence (1)
app/src/desktopMain/kotlin/com/crosspaste/ui/settings/SetStoragePathView.kt:81
- Consider using the HighlightedCard component instead of a plain Column here to maintain styling consistency with the other settings views.
.background(MaterialTheme.colorScheme.surfaceContainerHighest),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2702