Canvas Update #628

ghost · 2017-04-28T00:54:24Z

Add DrawFilledRectangle()

fanoI · 2017-04-29T09:00:35Z

Now I see that the code not compiled but do you have tried it on your machine before creating the PR?

I suggest you a more simpler approach instead to draw rectangles one inside the other it will be better to use DrawLine you can draw a simple draw horizontal lines until the rectangle has been filled.
If you want to test your modifications there is a Canvas TestRunner that you can use.

Thank you for the help!

valentinbreiz · 2017-04-29T12:43:36Z

I tried to compil cosmos with #628 and and Cosmos does not build.
And I tried to correct errors but @DjAlEx234 DrawFilledRectangle() does not work :/

fanoI · 2017-04-29T13:40:11Z

There is obviously no hurry :-)
Let @DjAlEx234 correct its code when he wants...

ghost · 2017-04-29T14:41:27Z

where is the test runner?

fanoI · 2017-04-29T15:37:07Z

The graphic TestRunner is here: https://github.com/CosmosOS/Cosmos/blob/master/Tests/GraphicTest/Kernel.cs

to enable it comment the other test and leave only it from here: https://github.com/CosmosOS/Cosmos/blob/master/Tests/Cosmos.TestRunner.Core/TestKernelSets.cs

you simply execute tests use the TestRunner project (the text mode one, the graphic based does not show Cosmos' console so no GUI seen!).

Fix spelling mistake and fix errors

jp2masa · 2017-04-29T19:49:08Z

source/Cosmos.System/Graphics/Canvas.cs

@@ -230,6 +230,29 @@ public void DrawRectangle(Pen pen, int x, int y, int width, int height)
            DrawLine(pen, xc, yc, xd, yd);
        }

+        public void DrawFilledRectangle(Pen pen, int x_start, int y_start, int width, int height)
+        {
+            for (int i; i != width; i++)


It should be int i = 0

jp2masa · 2017-04-29T19:50:23Z

source/Cosmos.System/Graphics/Canvas.cs

+            }
+        }
+
+        public void DrawSquare(Pen pen, int x, int y, int sideslength)


It doesn't make sense to have DrawSquare nor DrawFilledSquare, as it can be done using DrawRectangle and DrawFilledRectangle.

fanoI

We have decided that DrawSquare / DrawFilledSquare are in the end not needed.

Only a thing can you add to the CGS demo the Drawing of a filled rectangle?

fanoI · 2017-04-30T13:15:16Z

Another thing the methods that could be overriden by a driver that has these "shapes" in hardware should be done virtual so DrawLine(), DrawRectangle() and DrawFilledRectangle() must be all virtual so as all the methods requested in #603.

Thank you!

ghost · 2017-04-30T15:27:45Z

What do you mean by virtual?

fanoI · 2017-04-30T15:37:39Z

Add virtual modifier to the method for example:

 public virtual void DrawLine(Pen pen, int x1, int y1, int x2, int y2)

Bochs not having the capacity to draw lines in hardware will use this software implementation but a more powerful GPU (VmWare has already some emulated "hardware" capabilities) will override this method to implement its version of DrawLine() but it cannot do it if DrawLine() is not declared virtual in the Canvas abstract class.

ghost · 2017-04-30T15:41:26Z

So can I make a copy of every drawX void and make it virtual?

fanoI · 2017-04-30T15:49:00Z

No you not have to copy anything the methods: DrawLine(), DrawRectangle() and DrawFilledRectangle() must have the virtual modifier nothing else have to be changed.
The method Clear() is one example, in that case the Bochs driver ovverides it too because there is a more performant way to do it: https://github.com/CosmosOS/Cosmos/blob/master/source/Cosmos.System/Graphics/VBEScreen.cs#L99

The other methods in the more "shapes" issue should be virtual too maybe some very advanced GPU gives the possibility to draw triangles in hardware so it can be overridden too.

valentinbreiz · 2017-05-03T17:50:00Z

I'm writing the .DrawString method, here an exemple for the letter A:
canvas.DrawLine(pen, x, y + 1, x, y + 7);
canvas.DrawLine(pen, x + 4, y + 1, x + 4, y + 7);
canvas.DrawLine(pen, x + 1, y, x + 4, y);
canvas.DrawLine(pen, x + 1, y + 4, x + 4, y + 4);
There is a way to write this method well... faster ? x)

jp2masa · 2017-05-03T18:03:04Z

@valentinbreiz I don't know if we should have a DrawString method, it should be implemented by the graphics library, because fonts can be vectorial or use images for letters. The example you provided is vectorial, but it should be handled by the graphics library. We should provide methods for drawing vector images, like drawing lines, bézier curves... I don't know if we should handle drawing images, I think it should be implemented by a graphics library too.
@fanoI What do you think?

fanoI · 2017-05-03T19:50:06Z

DrawString() and DrawImage() was in the list of "CGS New Features" but I've put them there I didn't had analyzed how much difficult they where... probably as you say they deserve intermediate libraries that will use CGS as a building block.
Probably to do DrawString() efficiently the solution is to have before DrawImage() and to create the string as bitmap / vectorial imagine in memory, so to Draw a String we need:

Font support, makes sense in this age to support only TrueType that seems they have a sort of VM to be implemented to do correct rendering
Create the "image" of the String in Memory
C# DrawString class has Brushes, Styles a lot of things...
Draw the String as an Image

So in the end I'd say for now let's continue with what is in #603 that are really more primitive graphic types we think of "how to DrawImages" and "how to DrawStrings" after.

ghost · 2017-05-04T01:37:15Z

can we add a project that writes letters from a library?

fanoI · 2017-05-04T15:15:52Z

First a premise:
Text rendering is much complex issue then "pasting" some glyphs... Not just much complex, it is very complex: kerning, ligatures, spacing, bidirectional text, vowels, and much more...

Microsoft itself divides the problem in two parts DirectWrite and Direct2D / GDI+ (legacy), Direct2D is in some way the equivalent of our Canvas class.
https://en.wikipedia.org/wiki/DirectWrite

The OpenType format (successor of TrueType):
https://en.wikipedia.org/wiki/OpenType

In conclusion how to Draw Text in Cosmos needs more study and sure should affronted in a separated PR.

add stuff

jp2masa

Canvas methods to draw elements on the screen should be virtual.

jp2masa · 2017-05-21T21:23:08Z

source/Cosmos.System/Graphics/Canvas.cs

@@ -230,6 +230,22 @@ public void DrawRectangle(Pen pen, int x, int y, int width, int height)
            DrawLine(pen, xc, yc, xd, yd);
        }

+        public void DrawFilledRectangle(Pen pen, int x_start, int y_start, int width, int height)


This method should be virtual.

jp2masa · 2017-05-21T21:23:22Z

source/Cosmos.System/Graphics/Canvas.cs

+            }
+        }
+
+        public void DrawTriangle(Pen pen, int v1x, int v1y, int v2x, int v2y, int v3x, int v3y)


This method should be virtual.

prepare · 2018-06-26T12:11:23Z

Hello @fanoI,

I want to introduce a pure C# framework that can

Read OpenType font (.ttf, .otf)
Layout a string the glyph-spans and layout each glyph. (with OpenType glyph layout)
Render it to a Bitmap surface with grey-scale technique or with LCD-effect technique
(subpixel rendering)

Here =>https://github.com/LayoutFarm/Typography

I think my lib can help your graphics system.

:)

prepare · 2018-06-26T12:14:46Z

It is not only an advertisement. I want to help you too.

But I don't known much about Cosmos.

I need a time to learn your system first.

fanoI · 2018-06-27T08:06:43Z

@prepare thank you for your help offer!
We have already bitmap supported so drawing text is really the next step of CGS.

PM me if you have requests on how Cosmos works.

djalex124 added 2 commits April 27, 2017 19:50

Canvas Update

161e3c5

CGS

e1e5c01

ghost closed this Apr 28, 2017

fanoI reopened this Apr 29, 2017

djalex124 added 2 commits April 29, 2017 14:15

Should Work

d4c0729

Fix spelling mistake and fix errors

Merge remote-tracking branch 'refs/remotes/CosmosOS/master'

465b946

jp2masa requested changes Apr 29, 2017

View reviewed changes

changed

542db2e

jp2masa approved these changes Apr 30, 2017

View reviewed changes

jp2masa requested a review from fanoI April 30, 2017 00:34

fanoI approved these changes Apr 30, 2017

View reviewed changes

DrawTriangle

ac812db

update

297cbdf

add stuff

jp2masa requested changes May 21, 2017

View reviewed changes

Merge branch 'master' into master

eb944bb

Update Canvas.cs

adfb302

jp2masa approved these changes May 23, 2017

View reviewed changes

jp2masa merged commit e75262f into CosmosOS:master May 23, 2017

prepare mentioned this pull request Jul 4, 2018

CosmosOS RenderSurface Developing PaintLab/PixelFarm#31

Open

Canvas Update #628

Canvas Update #628

Uh oh!

Conversation

ghost commented Apr 28, 2017

Uh oh!

fanoI commented Apr 29, 2017

Uh oh!

valentinbreiz commented Apr 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanoI commented Apr 29, 2017

Uh oh!

ghost commented Apr 29, 2017

Uh oh!

fanoI commented Apr 29, 2017

Uh oh!

jp2masa Apr 29, 2017

Choose a reason for hiding this comment

Uh oh!

jp2masa Apr 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fanoI left a comment

Choose a reason for hiding this comment

Uh oh!

fanoI commented Apr 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 30, 2017

Uh oh!

fanoI commented Apr 30, 2017

Uh oh!

ghost commented Apr 30, 2017

Uh oh!

fanoI commented Apr 30, 2017

Uh oh!

valentinbreiz commented May 3, 2017

Uh oh!

jp2masa commented May 3, 2017

Uh oh!

fanoI commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 4, 2017

Uh oh!

fanoI commented May 4, 2017

Uh oh!

jp2masa left a comment

Choose a reason for hiding this comment

Uh oh!

jp2masa May 21, 2017

Choose a reason for hiding this comment

Uh oh!

jp2masa May 21, 2017

Choose a reason for hiding this comment

Uh oh!

prepare commented Jun 26, 2018

Uh oh!

prepare commented Jun 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanoI commented Jun 27, 2018

Uh oh!

Uh oh!

valentinbreiz commented Apr 29, 2017 •

edited

Loading

jp2masa Apr 29, 2017 •

edited

Loading

fanoI commented Apr 30, 2017 •

edited

Loading

fanoI commented May 3, 2017 •

edited

Loading

prepare commented Jun 26, 2018 •

edited

Loading