Skip to content

Improved tests #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DariuszDepta merged 7 commits into from
Nov 12, 2025
Merged

Improved tests #699

DariuszDepta merged 7 commits into from
Nov 12, 2025

Conversation

@DariuszDepta
Copy link
Member

@DariuszDepta DariuszDepta commented Nov 12, 2025 •
edited
Loading

  • Changed letter capitalization to Go convention - camel case.
  • Made constants and variables local in the module - no need to export them.
  • Added checks for pinned memory elements and size.
  • Added test for Pin, Unpin and GetPinnedMetrics functions.

@DariuszDepta DariuszDepta requested a review from pinosu November 12, 2025 14:10
@DariuszDepta DariuszDepta self-assigned this Nov 12, 2025
pinosu
pinosu requested changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we could cover few other tast cases e.g. try to pin / unpin non existing code.
Also you could use table driven tests

pinosu
pinosu approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DariuszDepta DariuszDepta merged commit 141f837 into main Nov 12, 2025
3 checks passed
@DariuszDepta DariuszDepta deleted the improved-tests branch November 12, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinosu pinosu pinosu approved these changes

Assignees

@DariuszDepta DariuszDepta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DariuszDepta @pinosu