cw20-escrow refactoring: Unify handling of native and cw20#92
Merged
cw20-escrow refactoring: Unify handling of native and cw20#92
Conversation
ethanfrey
reviewed
Sep 21, 2020
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Nice integration and ideas.
Added some comments to clean it up a bit more.
maurolacy
force-pushed
the
unify-cw20-native
branch
from
0fef0b6 to
ede00cf
Compare
maurolacy
force-pushed
the
unify-cw20-native
branch
from
e08aaca to
a8594cd
Compare
ethanfrey
approved these changes
Sep 23, 2020
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Looks good, merging.
Left some comment on a few style nitpicks, things for the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first iteration on #88.
This can be unified / simplified further, by example by introducing a
Cw20Balancetype. Or by introducing a genericCoin, that is a wrapper aroundNativeCoinandCw20Coin. But, better leave those for another task / PR.I'm not so happy with some of the trade-offs here. Like using a tuple type for the escrow balance. I also couldn't avoid code repetition in some parts, due to the structural differences between a
Coinand aCw20Coin. Maybe wrapping everything into a genericCoinis a good idea?