Use into_iter() instead of iter().cloned().#749
Merged
ueco-jb merged 1 commit intoCosmWasm:mainfrom Jul 8, 2022
Merged
Conversation
ueco-jb
approved these changes
Jul 6, 2022
Contributor
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
LGTM
Thank you for that, very good spot :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ought to be a little more efficient as we don't need to clone every element as we walk the list.
Just for fun, I wrote a little benchmark for this, then ran it with a couple different sizes using hyperfine. The
into_iter()method was around 1.5x as fast.