Add ability to unset minter in UpdateMinter message.#748
Merged
ueco-jb merged 4 commits intoCosmWasm:mainfrom Jul 18, 2022
Merged
Add ability to unset minter in UpdateMinter message.#748ueco-jb merged 4 commits intoCosmWasm:mainfrom
ueco-jb merged 4 commits intoCosmWasm:mainfrom
Conversation
0xekez
force-pushed
the
zeke/minter-removal
branch
from
9526f9a to
0d4eae4
Compare
ueco-jb
approved these changes
Jul 7, 2022
Contributor
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
LGTM
Very nicely spotted.
Thank you for contribution.
Contributor
|
@ezekiiel Could you also add entry to |
Contributor
Author
|
@ueco-jb done! thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to unset the minter in cw20's
UpdateMintermessage. Previously, the message only allowed for changing the minter to a new address.I do not believe that a new release has been cut since the
UpdateMintermessage was added so, so far as I understand, this shouldn't break any compatibility guarantees.Happy to take this elsewhere if this isn't wanted in the base cw20 specification.