Skip to content

add query_this_hook to hooks.rs#688

Merged
maurolacy merged 5 commits intoCosmWasm:mainfrom
ishaan0x:main
Jul 24, 2022
Merged

add query_this_hook to hooks.rs#688
maurolacy merged 5 commits intoCosmWasm:mainfrom
ishaan0x:main

Conversation

@ishaan0x
Copy link
Copy Markdown
Contributor

Added a function to hooks.rs that enables devs to check if a specific hook exists. Small but hopefully useful :)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 25, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribution

Copy link
Copy Markdown
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually if you are interested in learning more Rust, I encourage you to add some tests for that implementation.
I see that we don't have any hooks tests yet (to be done...), but you still could do that as an excercise.

ishaan0x and others added 3 commits July 24, 2022 09:22
Co-authored-by: Jakub Bogucki <software-solutions@tuta.io>
Co-authored-by: Jakub Bogucki <software-solutions@tuta.io>
@maurolacy maurolacy merged commit b2a1561 into CosmWasm:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants