Conversation
maurolacy
requested review from
ethanfrey,
hashedone,
ueco-jb,
uint and
webmaster128
ueco-jb
reviewed
Dec 16, 2021
ueco-jb
reviewed
Dec 16, 2021
Contributor
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
Good to see that this idea actually worked just fine.
maurolacy
force-pushed
the
489-signed-int-keys
branch
from
7bbaed9 to
a993938
Compare
ethanfrey
reviewed
Dec 16, 2021
ueco-jb
approved these changes
Dec 17, 2021
Contributor
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
lgtm
Personally I'd replace couple big numbers with constants for better transparency, but overall it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #489.
There are a number of different ways to do the signed int key modification (a number of different impls in the commits). Not sure what is the best one; opted for doing it without mutable slices, and without branching.
I guess the only way to know for sure would be by benchmarking them. Will create an issue for it, and we can do in the future.