Merged
Conversation
ueco-jb
force-pushed
the
549-migrate-intkey-to-naked-int-type
branch
2 times, most recently
from
3a6d5ac to
1bdd257
Compare
maurolacy
approved these changes
Dec 1, 2021
Contributor
maurolacy
left a comment
maurolacy
left a comment
There was a problem hiding this comment.
LGTM. Mostly cosmetic, looks better.
| let stage = LATEST_STAGE.update(deps.storage, |stage| -> StdResult<_> { Ok(stage + 1) })?; | ||
|
|
||
| MERKLE_ROOT.save(deps.storage, U8Key::from(stage), &merkle_root)?; | ||
| MERKLE_ROOT.save(deps.storage, stage, &merkle_root)?; |
Contributor
|
Regarding deprecation / removal of the |
ueco-jb
force-pushed
the
549-migrate-intkey-to-naked-int-type
branch
2 times, most recently
from
69a4dc5 to
f432eb9
Compare
ueco-jb
force-pushed
the
549-migrate-intkey-to-naked-int-type
branch
from
f432eb9 to
237ddee
Compare
maurolacy
reviewed
Dec 1, 2021
| /// let k = U64Key::new(12345); | ||
| /// let k = U32Key::from(12345); | ||
| /// let k: U16Key = 12345.into(); | ||
| #[deprecated(note = "It is suggested to use naked int types instead of IntKey wrapper")] |
ueco-jb
force-pushed
the
549-migrate-intkey-to-naked-int-type
branch
from
9baed5b to
0862505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #549
I succesfully replaced every
IntKeyusage both in contracts and packages (other then implementation itself + tests + de).Looking at overall progress, I could actually remove whole
IntKeyimplementation along with deserialization.I wonder if it wouldn't be too drastic? This seems to be major change, although from end user POV nothing changes - it's all internal.